[codex] Improve screen reliability and debug visibility#4
Open
devon7y wants to merge 1 commit into
Open
Conversation
shin-valterra-frontend
approved these changes
Apr 21, 2026
4 tasks
ethanplusai
added a commit
that referenced
this pull request
May 15, 2026
The background context worker had Open-Meteo coordinates and a location
label hardcoded to St. Petersburg, FL, so every JARVIS install — anywhere
in the world — reported St. Pete weather. Embarrassing for anyone running
this outside Tampa Bay.
- Resolves location dynamically via ipwho.is (no API key required),
cached for 15 minutes
- New env overrides for pinned locations:
WEATHER_LATITUDE / WEATHER_LONGITUDE (required pair to pin)
WEATHER_LOCATION_LABEL (display string, optional)
WEATHER_UNIT (fahrenheit | celsius, defaults to fahrenheit)
- Defaults to Fahrenheit to preserve existing behavior
- Falls back to "Weather data unavailable." silently if both env
override and IP lookup fail (no behavior regression)
- Removes the dead `async def fetch_weather()` wttr.in helper that
wasn't called from anywhere; the only live weather path was the
background worker in `_ctx_cache`
Tested live: IP-only path resolves to the caller's actual city,
env-override path correctly switches to specified lat/lon/unit.
Approach adapted from @devon7y's weather fix in PR #4.
Co-Authored-By: devon7y <devon7y@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
what is on my screen~/Desktopto common local dev roots and the current repoWhy
Several user-visible paths were brittle or misleading:
~/Desktop, which broke prompts against repos stored in normal local dev directoriesImpact
Validation
pytest -q tests/test_calendar_access.py tests/test_debug_log_stream.py tests/test_lookup_reporting.py tests/test_project_discovery.py tests/test_screen.py tests/test_screen_detection.py tests/test_weather.pynpm ci && npm run build