AA-522: Support alt-mempool configurations (WIP) #240
Conversation
| @@ -25,15 +27,50 @@ export interface BaseAltMempoolRule { | |||
| } | |||
|
|
|||
| export interface AltMempoolConfig { | |||
| [mempoolId: number]: { [rule in ERC7562Rule]?: BaseAltMempoolRule } | |||
| [mempoolId: string]: { [rule in ERC7562Rule]?: BaseAltMempoolRule } | |||
There was a problem hiding this comment.
using erc7562 rules as index is not that great: there is no easy 1-1 mapping from rule to code: many rules have code split in several places, and implementation that relates to multiple rules.
|
|
||
| type EnterOpcode = 'CALL' | 'DELEGATECALL' | 'CALLCODE' | 'STATICCALL' | 'CREATE' | 'CREATE2' | ||
| export type EnterOpcode = 'CALL' | 'DELEGATECALL' | 'CALLCODE' | 'STATICCALL' | 'CREATE' | 'CREATE2' | ||
|
|
||
| export interface AltMempoolRuleExceptionBase { | ||
| role?: Role |
There was a problem hiding this comment.
probably addresses, to apply same rule to multiple addresses.
There was a problem hiding this comment.
depth is very error-prone: for any depth other than 1, one can wrap a contract to use it.
There was a problem hiding this comment.
enterMethodSelector: should be an array: (e.g. allow all standard token APIs)
| @@ -25,15 +27,50 @@ export interface BaseAltMempoolRule { | |||
| } | |||
There was a problem hiding this comment.
RuleException: its nice that javascript allows dynamic typing (string/object), but it makes it harder to parse.
better use optional members. e.g: exceptions: [ { "role":"account" } ]
No description provided.