Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lammps update to separate lammps + gpu and lammps + kokkos #131

Merged
merged 29 commits into from
Feb 10, 2025
Merged

Lammps update to separate lammps + gpu and lammps + kokkos #131

merged 29 commits into from
Feb 10, 2025

Conversation

nickjbrowning
Copy link
Contributor

No description provided.

@nickjbrowning nickjbrowning requested a review from RMeli November 13, 2024 11:30
RMeli
RMeli requested changes Nov 13, 2024
View reviewed changes
Copy link
Member

@RMeli RMeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nickjbrowning, I left a few comments.

@nickjbrowning nickjbrowning requested a review from RMeli November 25, 2024 11:29
@RMeli
Copy link
Member

RMeli commented Dec 5, 2024

cscs-ci run alps;system=todi;uarch=gh200;uenv=lammps:2024

@nickjbrowning nickjbrowning requested a review from RMeli January 21, 2025 23:47
@nickjbrowning
Copy link
Contributor Author

nickjbrowning commented Jan 21, 2025 •
edited
Loading

I'm lacking write access so I can't merge @RMeli - could you take a final look and merge if all looks OK?

@RMeli
Copy link
Member

RMeli commented Feb 3, 2025

@nickjbrowning sorry, I completely missed the ping here. I'll have a look right away.

RMeli
RMeli approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@RMeli RMeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The only comment would be to change the docs to use uenv start --view <VIEW> <LAMMPS_UENV> instead of uenv start followed by uenv view which is no longer supported.

@RMeli
Copy link
Member

RMeli commented Feb 5, 2025

cscs-ci run alps;system=daint;uarch=gh200;uenv=lammps:2024

RMeli
RMeli approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@RMeli RMeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

The last commit only contains documentation changes, @msimberg and I already deployed the image on daint as lammps/2024:v2-rc1.

@RMeli RMeli merged commit a0b7511 into eth-cscs:main Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RMeli RMeli RMeli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickjbrowning @RMeli