Disable bounds check for WAMR - #22
Merged
Merged
Conversation
* Export shutdown function as workaround unclean exit issue * Reduces no. steps by 35%
psilva261
force-pushed
the
psilva261/wamr-bounds-check
branch
from
February 12, 2026 14:21
26968dd to
16ed03e
Compare
psilva261
marked this pull request as ready for review
February 12, 2026 14:21
* Use version that provides random_get
Benchmark Results (825e8f1)
|
Contributor
|
CC @marcinbugaj |
marcinbugaj
approved these changes
Feb 19, 2026
Collaborator
|
LGTM |
Contributor
|
Retrying benchmarks -- @marcinbugaj seems on average benchmarking takes about 40 minutes, do you know why? |
Benchmark Results (70b2865)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally
--bounds-check=1was introduced to allow for a clean exit. Since it creates a performance penalty, here is a workaround based on an explicitshutdowncall. This seems like a clean option for a quick fix, also since the languages in use do bounds checks anyway.