Fix admin translations in the edit profile page for Members #300
Conversation
dleske
left a comment
dleske
left a comment
There was a problem hiding this comment.
I didn't look at every single one. I scanned and then picked a dozen or so at random.
The variable names might be a bit easier if you use a different naming convention--simplest would be to leave off the abbreviation. For example, for the "Film and Media Studies Association of Canada (FMSAC)":
COM_MEMBERS_DYNAMIC_FILM_AND_MEDIA_STUDIES_ASSOCIATION_OF_CANADA= "Film and Media Studies Association of Canada (FMSAC)"
or categorizing, something like:
COM_MEMBERS_DYNAMIC_ASSOCIATIONS_FMSAC = "Film and Media Studies Association of Canada (FMSAC)"
But I don't know how these are used or what convention already exists.
I note that on the last line the spacing is inconsistent. The prior ones are all VAR=VAL but that one is VAR= VAL. Again I don't know what the convention is.
| COM_MEMBERS_DYNAMIC_ASSOCIATION_CANADIENNE_D___TUDES_FRANCOPHONES_DU_XIXE_SI__CLE__AC__F_XIX_="Association canadienne d'études francophones du XIXe siècle (ACÉF XIX)" | ||
| COM_MEMBERS_DYNAMIC_ASSOCIATION_DES_PROFESSEUR_E_S_DE_FRAN__AIS_DES_UNIVERSIT__S_ET_COLL__GES_CANADIENS__APFUCC_="Association des professeur.e.s de français des universités et collèges canadiens (APFUCC)" | ||
| COM_MEMBERS_DYNAMIC_ASSOCIATION_FOR_CANADIAN_AND_QU__BEC_LITERATURES__ACQL_="Association for Canadian and Québec Literatures (ACQL)" |
There was a problem hiding this comment.
For any variable names representing French or other characters I would suggest "É" should just be "E" and so on--for example for FRANÇAIS the variable name be FRANCAIS rather than FRAN__AIS which is harder to read.
Also for line 415, the "professeurs" part is probably supposed to be "professeur(e)s" - the optional "e" indicating a group of female professors (an all-male or mixed-gender group would be "professeurs"). I would also expect the parentheses to not be included in the official group name, but I'm not sure.
Huh wow. I just found their website and that's what they do. Okay, ignore this part!
|
Why are there |
Addresses #294.
The fix was to add the new translations to the members/admin component language folder.
2 new translations were also created (I used my own discretion as to what the title/translation should be) -
COM_MEMBERS_DYNAMIC_RESIDENCY = "Residency"COM_MEMBERS_DYNAMIC_EMPLOYMENT_STATUS = "Employment status"