Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial (?) fix for mainline issue 26 - routing maniphest tasks with … #61

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

blades
Copy link

@blades blades commented Sep 12, 2017

…multiple projects

@codecov
Copy link

codecov bot commented Sep 12, 2017

Codecov Report

Merging #61 into master will decrease coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
- Coverage   18.65%   18.59%   -0.07%     
==========================================
  Files          23       23              
  Lines         820      823       +3     
==========================================
  Hits          153      153              
- Misses        666      669       +3     
  Partials        1        1
Impacted Files Coverage Δ
app/controllers/feed.go 11.94% <0%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bef1f2d...ce23c14. Read the comment docs.

@schemar
Copy link
Collaborator

schemar commented Feb 27, 2018

@blades is this PR still relevant? If so can you please check the code formatting and style? And rebase on the latest master?
Thanks!

@blades
Copy link
Author

blades commented Feb 27, 2018 via email

@blades
Copy link
Author

blades commented Mar 1, 2018

i've merged with your recent changes now; no conflicts apparently so that would imply you've not done any work in the affected area.

@schemar
Copy link
Collaborator

schemar commented Mar 11, 2018

OK, thank you. I need more time to dig into this. But you are not forgotten!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants