Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update robustness doc and new case to reproduce 19179 #19353

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

fuweid
Copy link
Member

@fuweid fuweid commented Feb 6, 2025

NOTE: It's still hard to reproduce it. It may take 5 minutes or few hours.

Closes: #19304

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

cc @ahrtr @serathius @siyuanfoundation

@fuweid fuweid changed the title test: update robustness doc and new case to reproduce test: update robustness doc and new case to reproduce 19179 Feb 6, 2025
@fuweid fuweid force-pushed the fix-19179-robustness branch from b8dda9c to 9f4a0c1 Compare February 6, 2025 14:39
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.88%. Comparing base (f1d09c0) to head (8866fce).
Report is 4 commits behind head on main.

Additional details and impacted files

see 20 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19353      +/-   ##
==========================================
+ Coverage   68.83%   68.88%   +0.04%     
==========================================
  Files         420      420              
  Lines       35716    35716              
==========================================
+ Hits        24586    24602      +16     
+ Misses       9710     9694      -16     
  Partials     1420     1420              

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1d09c0...8866fce. Read the comment docs.

NOTE: It's still hard to reproduce it. It may take 5 minutes or few
hours.

Signed-off-by: Wei Fu <[email protected]>
@fuweid fuweid force-pushed the fix-19179-robustness branch from 9f4a0c1 to 8866fce Compare February 6, 2025 15:24
@fuweid
Copy link
Member Author

fuweid commented Feb 6, 2025

/retest

@siyuanfoundation
Copy link
Contributor

/lgtm

Thanks @fuweid !

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, fuweid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 8c263d2 into etcd-io:main Feb 6, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Document the #19179 in the etcd correctness track record
4 participants