build(deps): bump github.com/golangci/golangci-lint from 1.60.3 to 1.61.0 in /tools/mod #18596
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dependabot[bot] The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted filessee 24 files with indirect coverage changes @@ Coverage Diff @@
## main #18596 +/- ##
=======================================
Coverage 68.78% 68.79%
=======================================
Files 420 420
Lines 35474 35474
=======================================
+ Hits 24402 24405 +3
+ Misses 9652 9648 -4
- Partials 1420 1421 +1 Continue to review full report in Codecov by Sentry.
|
|
/ok-to-test |
|
/retest |
|
@dependabot rebase |
Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.60.3 to 1.61.0. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.60.3...v1.61.0) --- updated-dependencies: - dependency-name: github.com/golangci/golangci-lint dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/go_modules/tools/mod/github.com/golangci/golangci-lint-1.61.0
branch
from
0dbeb79
to
69fa7e3
Compare
|
@dependabot[bot]: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
This pr breaks [0;31mFAIL: inconsistent versions for dependency: google.golang.org/genproto/googleapis/rpc
- google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/api/v3
- google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/client/v3
- google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/etcdctl/v3
- google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/etcdutl/v3
- google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/pkg/v3
- google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/server/v3
- google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/tests/v3
- google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/tools/testgrid-analysis/v3
- google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/v3
- google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/tools/v3
�[0;31mFAIL: inconsistent dependencies We would need to bump it manually so we can bump the dependency everywhere. |
|
After |
On it |
Also fixed the following error by bumping google.golang.org/genproto/googleapis/rpc from v0.0.0-20240822170219-fc7c04adadcd to v0.0.0-20240903143218-8af14fe29dc1 FAIL: inconsistent versions for dependency: google.golang.org/genproto/googleapis/rpc - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/api/v3 - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/client/v3 - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/etcdctl/v3 - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/etcdutl/v3 - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/pkg/v3 - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/server/v3 - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/tests/v3 - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/tools/testgrid-analysis/v3 - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/v3 - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/tools/v3 - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/tools/v3 FAIL: inconsistent dependencies Reference: - etcd-io#18596 Signed-off-by: Chun-Hung Tseng <[email protected]>
…1.0 and google.golang.org/genproto/googleapis/rpc from v0.0.0-20240822170219-fc7c04adadcd to v0.0.0-20240903143218-8af14fe29dc1 Also fix the inconsistent version issue. Reference: - etcd-io#18596 Signed-off-by: Chun-Hung Tseng <[email protected]>
Based on the experience of performing dependency bumps, some minor improvements are made to the script to make it conform to our current dependency bump procedure, listed as follows: - print out the dependency's version before and after the bump - introduce a new argument: should force upgrade when the dependency is purely indirect (see use case: etcd-io#18596 (comment)) - check if the dependency is fully indirect - check if all dependencies across all go mod files have the same pinned version respectively after bumping a dependency Signed-off-by: Chun-Hung Tseng <[email protected]>
…1.0 and google.golang.org/genproto/googleapis/rpc from v0.0.0-20240822170219-fc7c04adadcd to v0.0.0-20240903143218-8af14fe29dc1 Also fix the inconsistent version issue. Reference: - etcd-io#18596 Signed-off-by: Chun-Hung Tseng <[email protected]>
Bumps github.com/golangci/golangci-lint from 1.60.3 to 1.61.0.
Release notes
Sourced from github.com/golangci/golangci-lint's releases.
Changelog
Sourced from github.com/golangci/golangci-lint's changelog.
Commits
a1d6c56build(deps): bump github.com/securego/gosec/v2 from 2.21.1 to 2.21.2 (#4997)48251f2build(deps): bump github.com/ckaznocha/intrange from 0.1.2 to 0.2.0 (#4996)bfc5247build(deps): bump github.com/tetafro/godot from 1.4.16 to 1.4.17 (#4993)57fa4dabuild(deps): bump github.com/ryancurrah/gomodguard from 1.3.3 to 1.3.5 (#4992)d302a30dev: fix nancy24e6645docs: add additionnal info about typecheck (#4985)bf4a66agosec: disable G407 (#4983)dd069d5build(deps): bump github.com/securego/gosec/v2 from 2.21.0 to 2.21.1 (#4982)2813c45build(deps): bump github.com/Crocmagnon/fatcontext from 0.4.0 to 0.5.2 (#4971)e9a8726build(deps): bump github.com/Abirdcfly/dupword from 0.0.14 to 0.1.1 (#4954)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)