Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade debian12 and bookworm #16487

Closed
wants to merge 2 commits into from
Closed

upgrade debian12 and bookworm #16487

wants to merge 2 commits into from

Conversation

SagarRawat24
Copy link
Contributor

signed-off-by: Sagar Rawat [email protected]

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for drafting this @SagarRawat24. We will need to hold off merging this until the Distroless image is ready.

@@ -1,5 +1,5 @@
ARG ARCH=amd64
FROM --platform=linux/${ARCH} gcr.io/distroless/static-debian11
FROM --platform=linux/${ARCH} gcr.io/distroless/static-debian12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the warning in the github issue, this should not be merged yet as https://console.cloud.google.com/gcr/images/distroless/GLOBAL/static-debian12 does not yet exist.

Refer: GoogleContainerTools/distroless#1337

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmhbnz is it image does not exist globally or error in code

Copy link
Member

@jmhbnz jmhbnz Aug 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @SagarRawat24 - The image now exists globally, so these tests should now pass if you re trigger them as follows:

git reset --soft HEAD~1
git commit -s -m "Update to Debian 12 bookworm."
git push --force

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @SagarRawat24 - It looks like there is one more file that needs to be updated, can you please check and update .github/workflows/e2e-arm64-template.yaml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants