Skip to content

Conversation

@kizzwell
Copy link

@kizzwell kizzwell commented Dec 1, 2025

Description

This fix ensures that the esx_identity:completedRegistration according to the official documentations gets triggered after a player completed their registration.


Motivation

This would help players to identify if the player has completed their registration and be able to integrate their own scripts to the framework regarding registration.


Implementation Details

Added the event trigger inside the if statement which was not being triggered due to returning early if xPlayer exists.


PR Checklist

  • [✅] My commit messages and PR title follow the Conventional Commits standard.
  • [✅] My changes have been tested locally and function as expected.
  • [✅] My PR does not introduce any breaking changes.
  • [✅] I have provided a clear explanation of what my PR does, including the reasoning behind the changes and any relevant context.

…tement to ensure that the event is being triggered according to the Official Documentation
@CLAassistant
Copy link

CLAassistant commented Dec 1, 2025

CLA assistant check
All committers have signed the CLA.

@Arctos2win
Copy link
Contributor

Arctos2win commented Dec 1, 2025

@CliqueDev25 in order for us to be able to merge it u must agree to our CLA (https://cla-assistant.io/esx-framework/esx_core?pullRequest=1763 )

@kizzwell
Copy link
Author

kizzwell commented Dec 1, 2025

@Arctos2win I now have accepted the license/cla.

@Arctos2win
Copy link
Contributor

Arctos2win commented Dec 10, 2025

@Arctos2win I now have accepted the license/cla.

Hi,

I have put someone within the team on refactoring esx_identity,
it will be fixed in that version.

Thanks for pointing this issue out !

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants