-
-
Notifications
You must be signed in to change notification settings - Fork 804
implement nationalities system / added countries.json #1746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
[core]/esx_identity/client/main.lua
Outdated
|
|
||
| RegisterNUICallback("ready", function(_, cb) | ||
| ready = true | ||
| SendNUIMessage({ type = "config", data = Config }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the
cbparam to send the data. So something likecb({ data = Config })No need to have another event sending the config, unnecessary.
Yep, that's a good idea. Thank you very much! Slipped my mind.
[core]/esx_identity/client/main.lua
Outdated
|
|
||
| RegisterNUICallback("ready", function(_, cb) | ||
| ready = true | ||
| SendNUIMessage({ type = "config", data = Config }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the cb param to send the data. So something like cb({ data = Config }) No need to have another event sending the config, unnecessary.
feat(es_extended): add xPlayer.updatePlayerData
- setNationality func to set the nationality and used updatePlayerData to sync the nationality on the client-side - getNationality func to return nationality as string value - removed the parts that use state bag
Zykem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, LGTM
|
|
Description
implemented nationalities system
Implementation Details
Usage Example
PR Checklist