-
-
Notifications
You must be signed in to change notification settings - Fork 804
feat(esx_identity/web): New UI #1740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
Woops. Accidentally duplicated files from the old version. Ill handle it. |
…th ESX.IsValidLocaleString Read more: esx-framework#1741 (comment)
|
Finished. |
|
Needs to fix the button to create the character sometimes it is out of the container |
…CSS file from old UI; new build
Kr3mu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The UI is too small ( especially the text ).
The bug with the height number:

The X mark on date is not centered:

The Birth date is not opening, tried waterfox and chromium browser (chromium).
Use vh instead of vw as if someone have ultra wide monitor the ui will be too big.
Use GetCurrentResourceName instead of hardcoding esx_identity
What's more your date validation just does year - 18 but what if you put december, you are not 18.
|
After posting I have noticed that look how much free space there is for example in select of gender |
|
To make it look better you can add simple opacity animation or other (just make it quick so people don't have to wait) - not really needed |
Description
Wrote a new UI for the esx_identity.
Motivation
Tasked. Revamps the old design.
Implementation Details
Implemented using Preact, Vite & TailwindCSS. Furthermore, most of the code is written in TypeScript.
Usage Example
Create a new character.
PR Checklist