-
-
Notifications
You must be signed in to change notification settings - Fork 803
fix(es_extended/server/modules/callback): refactor var naming & fix potential nil errors #1724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
WirzRexTon
wants to merge
28
commits into
esx-framework:dev
Choose a base branch
from
WirzRexTon:patch-1
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 45308f5.
Apparently, passing leading nil values via an export breaks it entirely.
feat: add auto-migrations on startup
…ment-isValid-on-register-command add a new argument on the register command feature
feat(esx_menu_default) Redesign of the menu.
fix(esx_menu_default): remove debug print
Renamed local variable table to request to avoid shadowing Lua's global table library.
Corrected function names ServerRecieve and ClientRecieve → ServerReceive / ClientReceive.
Standardized "unknown" string casing for GetInvokingResource() comparisons.
Added fallback in AwaitServerCallback: table.unpack(p.value or {}) to prevent nil errors.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed local variable table to request to avoid shadowing Lua's global table library.
Corrected function names ServerRecieve and ClientRecieve → ServerReceive / ClientReceive.
Standardized "unknown" string casing for GetInvokingResource() comparisons.
Added fallback in AwaitServerCallback: table.unpack(p.value or {}) to prevent nil errors.
Description
Motivation
Shadowing the Lua global table library with a local variable, which could break table.unpack.
Misspelled function names (ServerRecieve / ClientRecieve) causing confusion.
Inconsistent casing of "unknown" in resource checks, which could lead to logical errors.
Potential runtime errors if p.value is nil when awaiting a server callback.
Overall, these corrections improve code safety, reliability, and readability.
Implementation Details
Renamed the local variable table to request to preserve access to the global table library.
Corrected function names to ServerReceive and ClientReceive.
Standardized "unknown" string in all GetInvokingResource() comparisons.
Added a fallback in ESX.AwaitServerCallback: table.unpack(p.value or {}) to prevent nil errors.
PR Checklist