data-plane-controller: skip DNS await if nothing changed in pulumi up #1964
+142
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdibaiee
force-pushed
the
mahdi/skip-dns-await
branch
2 times, most recently
from
84353eb to
3c3ab46
Compare
mdibaiee
force-pushed
the
mahdi/skip-dns-await
branch
from
3c3ab46 to
3f7c378
Compare
jgraettinger
approved these changes
Feb 25, 2025
| state.last_pulumi_up = chrono::Utc::now(); | ||
|
|
||
| Ok(DNS_TTL) | ||
| if resource_changes.changed() { |
There was a problem hiding this comment.
nit: you can make this more concise, by having the if block return a tuple of (status, poll-result, log-line).
| ); | ||
| } | ||
|
|
||
| let mut out: Vec<stack::PulumiStackHistory> = serde_json::from_slice(&output.stdout).context("failed to parse pulumi stack history output")?; |
mdibaiee
force-pushed
the
mahdi/skip-dns-await
branch
from
b8b157d to
7262230
Compare
mdibaiee
force-pushed
the
mahdi/skip-dns-await
branch
from
7262230 to
2b84796
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
(anything that might help someone review this PR)
This change is