Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #365 #437

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

Fix #365 #437

wants to merge 27 commits into from

Conversation

lucivpav
Copy link

@lucivpav lucivpav commented Dec 21, 2020

Fixes issue #365 (maybe more).

Changes:

Fixes wrong code generation when using comments in return, throw and arrow function expressions.
add tests
the trailing comments are still the same (incorrect placement), but they do not affect the syntax (can be addressed in a future PR)
blank line preservation: seems no new problems with this

This PR is a continuation of PR #425

@lucivpav
Copy link
Author

@Constellation can you please review this, when you have time?

@lucivpav
Copy link
Author

lucivpav commented Dec 21, 2020

CI is failing on master too

@lucivpav
Copy link
Author

@michaelficarra could you please take a look at this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant