Skip to content

[widagps] Remember the last AGPS update (no request on every app load) - #4429

Draft
jmlich wants to merge 1 commit into
espruino:masterfrom
jmlich:widagps-fixes
Draft

jmlich wants to merge 1 commit into
espruino:masterfrom
jmlich:widagps-fixes

Conversation

@jmlich

@jmlich jmlich commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Turning the GPS off right after the Serial1 writes aborts the transfer while up to 255 bytes are still being sent. On firmware 2v29 this leaves the UART marked as sending, so the next Serial1.write of 255 bytes or more (the next AGPS update) blocks forever in jshTransmit. Turn the GPS off 1 s later instead, like agpsdata does.

Also restore lastAGPS from agpsdata.json, so the widget no longer asks for AGPS on every app load, and only apply http replies to its own requests.

AI-assisted

The #4417 improves behaviour, but this should fix it.
Javascript shouldn't hang device in first place espruino/Espruino#2782

@github-actions

Copy link
Copy Markdown

tagging @pidajo for apps/widagps

@jmlich jmlich changed the title widagps 0.03: Fix hang, remember the last AGPS update [widagps] Fix hang, remember the last AGPS update Nov 17, 2026
@jmlich jmlich changed the title [widagps] Fix hang, remember the last AGPS update [widagps] Remember the last AGPS update (no request on every app load) Nov 18, 2026
Restore lastAGPS from agpsdata.json, so the widget no longer asks for
AGPS on every app load.

AI-assisted
@jmlich

jmlich commented Nov 18, 2026

Copy link
Copy Markdown
Contributor Author

The 03d078b fixed the hang issue, but AGPS update is triggered on every restart of widget. I am not sure if this is intend behaviour

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant