Repository navigation
Conversation
|
tagging @pidajo for |
jmlich
force-pushed
the
widagps-fixes
branch
from
November 17, 2026 14:49
6ba0b38 to
6991ae3
Compare
jmlich
force-pushed
the
widagps-fixes
branch
from
November 18, 2026 11:11
6991ae3 to
b4fd2d5
Compare
Restore lastAGPS from agpsdata.json, so the widget no longer asks for AGPS on every app load. AI-assisted
jmlich
force-pushed
the
widagps-fixes
branch
from
November 18, 2026 11:14
b4fd2d5 to
e49c01d
Compare
Contributor
Author
|
The 03d078b fixed the hang issue, but AGPS update is triggered on every restart of widget. I am not sure if this is intend behaviour |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turning the GPS off right after the Serial1 writes aborts the transfer while up to 255 bytes are still being sent. On firmware 2v29 this leaves the UART marked as sending, so the next Serial1.write of 255 bytes or more (the next AGPS update) blocks forever in jshTransmit. Turn the GPS off 1 s later instead, like agpsdata does.
Also restore lastAGPS from agpsdata.json, so the widget no longer asks for AGPS on every app load, and only apply http replies to its own requests.
AI-assisted
The #4417 improves behaviour, but this should fix it.
Javascript shouldn't hang device in first place espruino/Espruino#2782