-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Tag app authors in PRs to their apps #3935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@gfwilliams @thyttan what do you think? |
d35e630
to
637b551
Compare
Seems it can only include people with write access. Maybe we have a script parse this file to tag those without write access? |
In theory it's good to have a common place, but having to look apps up in one text file seems almost as hard as clicking the GitHub icon next to an app and looking at the history? Could this be a new field in the metadata file? Npm uses "author". The app loader could easily pick it up then? |
Yes, the problem with git history is there's a lot of commits by non-owners of the app, so a lookup isn't always trivial and my goal is to see if we can get a script to automatically tag the owner. An author field sounds good, more localised too! We could try out this setup I've changed to |
0a784ad
to
9cc4eea
Compare
In my head the word owner rings a little bad in this open source context. Author sounds better to me. But maybe that's just me bikeshedding 🙃 |
Agreed! |
This looks good - looks like the mention-app-authors thing fails though - maybe due to excessive requests? https://github.com/espruino/BangleApps/actions/runs/16239627985/job/45854268885?pr=3935 Might be easier to just run it manually and add it to the PR that way? Please can you also add a mention in the README on the format? https://github.com/espruino/BangleApps?tab=readme-ov-file#metadatajson-format And the tutorial is going to need changing too: https://github.com/espruino/EspruinoDocs/blob/master/tutorials/Bangle.js%20App%20Loader.md#adding-your-app You're probably not going to like this, but do you think you'd be able to insert the |
Yeah I need to debug that 403, I'll get it working then sort out the surrounding bits - good catches |
As seen in #3932, it can take a bit of research to find the author of an app. This PR adds a
CODEOWNERS
file so owners can add themselves to be notified of PRs which might need their review.I've added a few people who I could programatically glean from the git history