swipeinv: (WIP) Add inversion of drag events. Refactor to hijack and modify the events #3815
+96
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 20, 2025 20:20
…modify the events instead of the handling of them. This should add compatibility with most apps, even if Bangle.setUI is not used.
thyttan
changed the title
|
Nice, I have not tested this, but looks good to me. |
added 10 commits
April 28, 2025 22:52
|
I think this works now, can be tried at https://thyttan.github.io/BangleApps/?id=swipeinv not looking to merge yet though. |
|
@thyttan looks interesting, I'll give it a try when I get a chance, thanks |
|
I think I notice this approach making the watch feel a bit slower than the old one. So that's a minus in that case. But not conclusive, just a feeling. |
|
I also had the idea to do the inversions by wrapping the listener functions at their registration. That way It's here: thyttan@5cbb72e But I didn't get that to work yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... instead of the handling of them. This should add compatibility with
most apps, even if Bangle.setUI is not used.
Ping @nxdefiant and @jt-nti , what do you think of this approach?
I'm also thinking of adding settings so horizontal and vertical inversion can be set individually, also per app.