launch: fix fullscreen and showClocks setting #3788

thyttan · 2025-03-29T23:04:30Z

0.24: Fix fullscreen when fastloading the launcher. (TODO:fix back btn flicker)
Fix respecting the showClocks setting.

Try it via my app loader: https://thyttan.github.io/BangleApps/?id=launch

closes #3786 and #3785

@gfwilliams because it is a core app.

...by now clearing cache when changing those settings.

gfwilliams · 2025-03-31T09:14:39Z

Thanks! This looks great!

For the flicker, I guess there are some options:

if when we weren't showing widgets we didn't add a back handler but instead just add a setWatch on the button?
Maybe Bangle.setUI shouldn't display a 'back' widget if there are no widgets currently loaded?
It looks like if you defined WIDGETS.back = {remove:()=>{}}; beforehand when fullscreen then it might stop a redraw? Bit of a hack though! https://github.com/espruino/Espruino/blob/master/libs/js/banglejs/Bangle_setUI_Q3.js#L9-L12

bobrippling · 2025-03-31T15:14:43Z

apps/launch/app.js

@@ -81,8 +84,14 @@
        // cleanup the timeout to not leave anything behind after being removed from ram
        if (lockTimeout) clearTimeout(lockTimeout);
        Bangle.removeListener("lock", lockHandler);
+        // Restore widgets if they were hidden by fullscreen setting
+        if (global.WIDGETS) require("widget_utils").show();


Do we also need:

Suggested change

if (global.WIDGETS) require("widget_utils").show();

if (global.WIDGETS || settings.fullscreen) require("widget_utils").show();

or perhaps:

Suggested change

if (global.WIDGETS) require("widget_utils").show();

if (hiddenWidgets) require("widget_utils").show();

(with that bool set when we call widget utils' hide())

I think we might be ok: https://github.com/espruino/BangleApps/blob/master/modules/widget_utils.js#L21

But it feels like a good idea to check anyway as otherwise it may force a redraw? Did you mean if (global.WIDGETS && settings.fullscreen) instead?

Ah no - we're looking at it from different sides. Your side is whether it's safe to call (so I can see why you're thinking && and the widget._draw check), mine is if we need to undo our changes, which are either if we've done a .hide() from having widgets:

BangleApps/apps/launch/app.js

Lines 27 to 28 in 5dd73bb

} else if (global.WIDGETS) {

require("widget_utils").hide();

or if we've had the fullscreen setting:

BangleApps/apps/launch/app.js

Lines 91 to 92 in 5dd73bb

if (settings.fullscreen) {

require("widget_utils").hide();

If either of those are true, we need to .show(), hence global.WIDGETS || settings.fullscreen, right?

But if there are no widgets, there's no need to update their properties with the .show() call - right? There's nothing for widget-utils to act on.

Yes, but then the for loop wouldn't be entered in that case so we're ok, still. And we're balancing our above call to .hide(), which I think is as far as this code needs to go, and it can then trust that widget_utils will do the right thing

Ahh, right - I see what you mean - but actually we only call require("widget_utils").hide(); when we're supposed to be in fullscreen mode (line 27 is actually if (!fullscreen) {..} else if (...WIDGETS) ....

If we're not in fullscreen mode we almost certainly do have widgets but they're not hidden.

Ah I hadn't spotted the fullscreen check, yeah I'm with you

thyttan · 2025-04-01T08:43:49Z

apps/launch/app.js

      }
    });
+    if (settings.fullscreen) {
+      require("widget_utils").hide();


@bobrippling this makes me think you may be right regarding L88

But we also have this consideration about maybe changing the back-function behaviour: #3788 (comment)

That's true, it is a bit of a special case I suppose. Perhaps we try out a few different approaches?

Ok - so in this case the widgets would have been hidden before (if there were any), but because we're using back a widget is being added anyway and so we're having to hide them again?

I feel we should probably just fix the back issue rather than having these lines in there?

gfwilliams · 2025-04-01T09:02:41Z

@thyttan @bobrippling I think there's a question about whether setUI should actually show a back button if there are no widgets? If it didn't it'd make this a lot tidier (no flicker or code needed on line 91)

So right now WIDGETS is defined if you call Bangle.loadWidgets() (even if there are no widgets), and is undefined if not. But then supplying back in setUI creates the WIDGETS object (and leaves it set). It just feels wrong to me.

So are you ok with me fixing that? Supplying back in setUI would still work then (with the button press) but it just wouldn't show the icon in the top left.

thyttan · 2025-04-01T09:06:08Z

Without thinking too much about it - yes I like that solution!

thyttan · 2025-04-01T09:07:47Z

I'm debating in my head if the touch in top left corner should still work though even when the widget is not displayed. Could be neat. But maybe not?

gfwilliams · 2025-04-01T09:11:52Z

Yeah, although I wonder whether someone might tap in the launcher and expect to launch the app?

I was considering making setUI use an overlay to display the back button in that case, but it just feels like overkill!

thyttan · 2025-04-01T09:18:53Z

Yeah, although I wonder whether someone might tap in the launcher and expect to launch the app?

It's such a small area that it shouldn't happen very often. But I'm not sure which way is best.

I was considering making setUI use an overlay to display the back button in that case, but it just feels like overkill!

Agreed. It could be cool - but probably not worth the overhead?

I'd like it in the context of my messagegui changes - but not if it impacts scrolling drawing performance/input latency.

thyttan · 2025-04-01T09:21:06Z

(For messagegui it's E.showScroller and not Bangle.setUI though)

bobrippling · 2025-04-01T09:24:19Z

I suppose one question would be, for apps without widgets do users regularly use the back button anyway? Or are they more likely to soft-reset to escape? Or are we talking menus?

gfwilliams · 2025-04-01T09:37:46Z

For messagegui it's E.showScroller and not Bangle.setUI though

Ahh - yes, I looked at that. It seems showScroller calls setUI under the hood :)

Having the overlay definitely would hurt scroll performance, so maybe we forget that for now.

for apps without widgets do users regularly use the back button anyway? Or are they more likely to soft-reset to escape? Or are we talking menus?

Yes, I think they'd almost certainly use the button. I reckon if the whole screen is being used there's a high likelihood that UI elements might end up being over that top left area anyway - imagine if you have a menu with no title - the top menu item would then be forever half obscured by the back button.

I'll go fix setUI then...

…ng back icon

gfwilliams · 2025-04-01T10:28:54Z

Huh, well I did that - and I guess as expected it wasn't that easy! Because when widgets are there but hidden WIDGETS is still defined - so I had to check if the widget bar was there. Fixed now though 453def81645c08e46195ad0627c1b77c8a59ee2a

I've updated the launcher code - does this look ok now? Obv it'll need new firmware but I should probably do a release soon anyway

thyttan · 2025-04-01T10:53:11Z

Nice!

I believe so - didn't test now though

bobrippling · 2025-04-01T11:45:53Z

Cool, yeah LGTM too

gfwilliams · 2025-04-01T12:46:16Z

Just FYI I added another change which allows the item height to be adjusted independently of the font.

thyttan added 2 commits March 29, 2025 23:56

launch: refactor fullscreen to load and hide widgets

c28b6d3

launch: Fix showClocks setting not taking effect

5dd73bb

...by now clearing cache when changing those settings.

thyttan force-pushed the launch branch from c9c1c15 to 5dd73bb Compare March 30, 2025 09:25

bobrippling linked an issue Mar 31, 2025 that may be closed by this pull request

[launcher] fullscreen setting doesn't work #3785

Closed

bobrippling reviewed Mar 31, 2025

View reviewed changes

thyttan commented Apr 1, 2025

View reviewed changes

Merge branch 'master' into launch

b26bcad

gfwilliams added 2 commits April 1, 2025 11:26

Update app.js after having stopped setUI in latest firmware from addi…

1702b15

…ng back icon

Fix lint

144d938

gfwilliams merged commit fe14434 into espruino:master Apr 1, 2025
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

launch: fix fullscreen and showClocks setting #3788

launch: fix fullscreen and showClocks setting #3788

thyttan commented Mar 29, 2025 •

edited

Loading

gfwilliams commented Mar 31, 2025

bobrippling Mar 31, 2025

gfwilliams Mar 31, 2025

bobrippling Apr 1, 2025

thyttan Apr 1, 2025

bobrippling Apr 1, 2025

gfwilliams Apr 1, 2025

bobrippling Apr 1, 2025

thyttan Apr 1, 2025

thyttan Apr 1, 2025

bobrippling Apr 1, 2025

gfwilliams Apr 1, 2025

gfwilliams commented Apr 1, 2025 •

edited

Loading

thyttan commented Apr 1, 2025

thyttan commented Apr 1, 2025 •

edited

Loading

gfwilliams commented Apr 1, 2025

thyttan commented Apr 1, 2025

thyttan commented Apr 1, 2025

bobrippling commented Apr 1, 2025

gfwilliams commented Apr 1, 2025

gfwilliams commented Apr 1, 2025

thyttan commented Apr 1, 2025

bobrippling commented Apr 1, 2025

gfwilliams commented Apr 1, 2025

	if (global.WIDGETS) require("widget_utils").show();
	if (global.WIDGETS \|\| settings.fullscreen) require("widget_utils").show();

	if (global.WIDGETS) require("widget_utils").show();
	if (hiddenWidgets) require("widget_utils").show();

launch: fix fullscreen and showClocks setting #3788

launch: fix fullscreen and showClocks setting #3788

Conversation

thyttan commented Mar 29, 2025 • edited Loading

gfwilliams commented Mar 31, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gfwilliams commented Apr 1, 2025 • edited Loading

thyttan commented Apr 1, 2025

thyttan commented Apr 1, 2025 • edited Loading

gfwilliams commented Apr 1, 2025

thyttan commented Apr 1, 2025

thyttan commented Apr 1, 2025

bobrippling commented Apr 1, 2025

gfwilliams commented Apr 1, 2025

gfwilliams commented Apr 1, 2025

thyttan commented Apr 1, 2025

bobrippling commented Apr 1, 2025

gfwilliams commented Apr 1, 2025

thyttan commented Mar 29, 2025 •

edited

Loading

gfwilliams commented Apr 1, 2025 •

edited

Loading

thyttan commented Apr 1, 2025 •

edited

Loading