Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

splitsw: add new stopwatch app with split timer #3504

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

jt-nti
Copy link
Contributor

@jt-nti jt-nti commented Jul 12, 2024

No description provided.

@jt-nti jt-nti force-pushed the split-stopwatch branch from adbf6d1 to fa15dd2 Compare July 13, 2024 09:39
@jt-nti jt-nti force-pushed the split-stopwatch branch from fa15dd2 to 9402124 Compare July 13, 2024 09:45
@thyttan
Copy link
Collaborator

thyttan commented Jul 15, 2024

Nice one, thanks!

There are a couple of timer apps now - maybe we should have a library/module for the core functionality eventually?

@thyttan thyttan merged commit b0949d6 into espruino:master Jul 15, 2024
1 check passed
@jt-nti
Copy link
Contributor Author

jt-nti commented Jul 16, 2024

A library/module for some shared timer functionality definitely sounds like a good idea.

@bobrippling
Copy link
Collaborator

bobrippling commented Aug 2, 2024

Very nice app! I've noticed one thing, not sure if it's just me - I notice I don't get any backlight in this app, perhaps it's because the timout is set, so if the backlight is off it never turns on?

@jt-nti
Copy link
Contributor Author

jt-nti commented Aug 2, 2024

That's odd, the backlight stays on for me, which is what I expected from http://www.espruino.com/ReferenceBANGLEJS2#l_Bangle_setLCDTimeout

I was already thinking of adding some options to override the Backlight and Lock timeouts separately, so that might fix the issue for you. I'll try to have a look if I get a chance.

@bobrippling
Copy link
Collaborator

Sounds good, thank you! I'll keep my eyes peeled :)

@jt-nti
Copy link
Contributor Author

jt-nti commented Aug 24, 2024

@bobrippling
I've made a start on #3542 which may already fix your backlight issue. I'd be interested if it doesn't anyway!

I'm kind of undecided about having separate options for the screen lock and backlight, especially since my cunning plan to add support for the physical button, even when locked, isn't going too well.

I'm also wondering about better names for the options since I think even I'm confussed byt the current names! Maybe "Keep backlight on" and "Stay unlocked" would be clearer?

@bobrippling
Copy link
Collaborator

Awesome! Yes that's a fair point, we can see how the cunning plan plays out - I have a few ideas to act on the button press even when locked:

Bangle.on("lock", (locked, reason) => {
  if (!locked && reason === "button") {
    buttonPress();
  }
})

Those option names sound good too, let's see how they look though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants