Fix: increase ESP32-S3 Bluetooth tasks stack size to 8k #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
|
if this is causing issues on more than one board, would it not make sense to set it for all chips? |
|
I did the change only to the ESP32-S3 because I'm not sure how the other chips behave as I don't own them, but if you're okay with that I can also just move the two options to |
|
yes please :) |
|
Done ✅ |
Dabolus
force-pushed
the
fix/esp32s3-low-stack-size-crash
branch
from
e222126 to
800d7b0
Compare
|
Sorry, I had committed with the wrong email address. Now it should be fine. |
|
@me-no-dev do the changes look good now? Can this be merged? |
|
yes, will merge soon. |
|
Great, thanks! ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the ESP32-S3 Bluetooth tasks stack size to 8k as it was already done for the standard ESP32 to avoid the crashes that happen when connecting to some devices such as the Polar H10 heart monitor.
See this issue for more context/information.