Skip to content

Add OTA to senseBox Eye board #11684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add OTA to senseBox Eye board #11684

wants to merge 4 commits into from
+336 −8

Conversation

PaulaScharf
Copy link
Contributor

Description of Change

Adding over-the Air upload upload scripts.

Tests scenarios

I have tested this pull request on the senseBox Eye board.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 1, 2025 •
edited
Loading

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello PaulaScharf, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 15ac3c7

tonhuisman
tonhuisman reviewed Aug 1, 2025
View reviewed changes
variants/sensebox_eye/APOTA.ino Outdated
// Restart to boot from the new partition
esp_restart();
} else {
Serial.println("OTA1 partition not found!");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing the context, this message is probably supposed to mention OTA0, not OTA1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very true, I changed it

tonhuisman
tonhuisman reviewed Aug 1, 2025
View reviewed changes
variants/sensebox_eye/APOTA.ino
Comment on lines +144 to +146
display.println("Verbinde dich"); // "Connect"
display.setCursor(60, 27);
display.println("mit:"); // "with"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All log messages are English, why not also use English on the display?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The board is mainly sold in germany and OTA is mainly used in workshops in schools also in germany

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope these students also learn to use English, as the software world is very much English oriented 😆

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least it is not consistent. It is a mix of English and German.

@lucasssvaz lucasssvaz added the Type: 3rd party Boards Related to third-party/non-Espressif hardware boards. label Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonhuisman tonhuisman tonhuisman left review comments

@Jason2866 Jason2866 Jason2866 left review comments

@P-R-O-C-H-Y P-R-O-C-H-Y Awaiting requested review from P-R-O-C-H-Y P-R-O-C-H-Y is a code owner

At least 0 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Type: 3rd party Boards Related to third-party/non-Espressif hardware boards.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PaulaScharf @tonhuisman @Jason2866 @lucasssvaz