feat(uart): fixes loopback function after IDF changes #11492
+11
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IDF 5.4.1 has added a new function called uart_release_pin() that is called whenever new pins are set or when uart driver is deleted. This has a side effect that causes RX pin to never work again with the loopback function. Other changes also have removed some GPIO setup that was necessary for the GPIO loopback mode work. The PR forces a full RX Pin setup in order to make it work in GPIO Matrix with Loopback TX Signal
SuGlider
moved this from Todo
to Under investigation
in Arduino ESP32 Core Project Roadmap
👋 Hello SuGlider, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results 76 files 76 suites 12m 40s ⏱️ Results for commit 4df11ef. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Pull Request Overview
This PR restores UART loopback functionality by reconfiguring the RX pin after IDF 5.4.1’s uart_release_pin() behavior.
- Swapped out
soc/uart_periph.hforsoc/uart_pins.hand addedesp_private/gpio.h - Removed legacy TX/RX signal macros and updated loopback comments
- Rewrote
uart_internal_loopbackto explicitly reinitialize the RX pin via GPIO matrix before connecting signals
Comments suppressed due to low confidence (2)
cores/esp32/esp32-hal-uart.c:1401
- [nitpick] The comment could be clearer and grammatically improved—for example, describe how
uart_release_pin()altered default pin routing in IDF 5.4.1 and why these GPIO calls restore loopback.
// forces rxPin to use GPIO Matrix and setup the pin to receive UART TX Signal - IDF 5.4.1 Change with uart_release_pin()
cores/esp32/esp32-hal-uart.c:1402
- Since the loopback relies on these new GPIO calls, add a CI or unit test to verify
uart_internal_loopbackworks correctly after IDF 5.4.1 changes.
gpio_func_sel((gpio_num_t) rxPin, PIN_FUNC_GPIO);
Co-authored-by: Copilot <[email protected]>
|
@me-no-dev : This PR shall fix #11416 after the IDF Change done by the commit espressif/esp-idf@60f5828 |
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
me-no-dev
approved these changes
Jun 21, 2025
|
The PR does not fix the issue @SuGlider @me-no-dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
IDF 5.4.1 has added a new function called uart_release_pin() that is called whenever new pins are set or when uart driver is deleted.
This has a side effect that causes RX pin to never work again with the loopback function. Other changes also have removed some GPIO setup that was necessary for the GPIO loopback mode work.
This PR forces a full RX Pin setup in order to make it work in GPIO Matrix with Loopback TX Signal
Tests scenarios
CI Only
Related links
CI error