-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Clarify accuracy_decimals in sensor #4837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: current
Are you sure you want to change the base?
Conversation
WalkthroughThe change updates the documentation for the Changes
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
components/sensor/index.rst (1)
59-67
: Documentation Clarity: Capitalization and spacing consistency
The phrase “esphome integration” should be capitalized to “ESPHome integration” to align with project naming. Also, there’s an extra space before “The number of digits…”—it’s best to keep a single space after periods for consistency.Proposed diff:
- While this - does not change the value sent across the API, Home Assistant's esphome integration will round the value accordingly before using or - storing it. The number of digits will also be used to set the + While this does not change the value sent across the API, Home Assistant's ESPHome integration will round the value accordingly before using or storing it. The number of digits will also be used to set the
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
components/sensor/index.rst
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`**`: - Do not generate or add any sequence diagrams
**
: - Do not generate or add any sequence diagrams
components/sensor/index.rst
✅ Deploy Preview for esphome ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
While accuracy_decimals doesn't change the value sent across the API, Home Assistant rounds at ingestion time. Explain this, so that people will realize that if they want e.g. 0.01C in Home Assistant, they need to change accuracy_decimals and can't just change the entity's display resolution.
802e1a5
to
e2594cd
Compare
While accuracy_decimals doesn't change the value sent across the API,
Home Assistant rounds at ingestion time. Explain this, so that
people will realize that if they want e.g. 0.01C in Home Assistant,
they need to change accuracy_decimals and can't just change the
entity's display resolution.
Description:
esphome/issues#5830
https://community.home-assistant.io/t/difference-between-accuracy-decimals-and-round/703755/16
Checklist:
I am merging into
next
because this is new documentation that has a matching pull-request in esphome as linked above.or
I am merging into
current
because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.Link added in
/components/index.rst
when creating new documents for new components or cookbook.