-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new OTA method #754
base: main
Are you sure you want to change the base?
Added new OTA method #754
Conversation
Added new OTA method and a new "standard" default example code.
✅ Deploy Preview for esphome-devices ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things:
Lets not change the names an friendly names since these configs are for specific devices and the existing ones make sense.
Also, lets not remove captive_portal
because if people can only ota flash a device and dont add wifi credentials, it will be difficult to update it again.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
OK I will keep that in mind and revert the couple that changed the friendly names. Will keep in captive_portal if it is there already. |
Added the captive_portal: to standard code block
Added new OTA method and a new "standard" default example code.
Added new OTA method and a new "standard" default example code.
Added new OTA method and a new "standard" default example code.
Added new OTA method and a new "standard" default example code.
Added new OTA method and a new "standard" default example code.
Added new OTA method and a new "standard" default example code.
Added new OTA method and a new "standard" default example code.
Added new OTA method and a new "standard" default example code.
Added new OTA method and a new "standard" default example code.
Added new OTA method and a new "standard" default example code.
Added new OTA method and a new "standard" default example code.
Added new OTA method and a new "standard" default example code.
Added new OTA method and a new "standard" default example code.
Added new OTA method and a new "standard" default example code.
Added new OTA method and a new "standard" default example code.
Added new OTA method and a new "standard" default example code.
Added new OTA method and a new "standard" default example code.