Skip to content

Disable "Invalid identification string" test #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Disable "Invalid identification string" test #24

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33763d4
Update parser.h
JeroenWiersma Dec 28, 2024
ace3f97
Merge pull request #1 from JeroenWiersma/Invalid_identification_strin…
JeroenWiersma Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/dsmr/parser.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,8 +405,8 @@ namespace dsmr
// passed '3' here (which is mandatory for "mode D"
// communication according to 62956-21), so we also allow
// that.
if (line_start + 3 >= line_end || (line_start[3] != '5' && line_start[3] != '3'))
return res.fail("Invalid identification string", line_start);
//if (line_start + 3 >= line_end || (line_start[3] != '5' && line_start[3] != '3'))
// return res.fail("Invalid identification string", line_start);
// Offer it for processing using the all-ones Obis ID, which
// is not otherwise valid.
ParseResult<void> tmp = data->parse_line(ObisId(255, 255, 255, 255, 255, 255), line_start, line_end);
Expand Down