Refactoring: remove the FirmwareImage trait and eliminate the elf module
#802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes should be pretty straightforward I hope. This is still just one of many refactoring PRs, so nothing is set in stone yet and there are still further changes to make.
One notable omission here is a generic interface for application image formats; I'm working on this but it's not ready yet, and I'd like to get these changes merged at least.
This also exposes
xmas_elf::ElfFilein the public API, which is not a stable dependency, so this will need to be resolved. I will open an issue to keep track of this and resolve it in a later PR, probably when the aforementioned interface is created.This closes #792, as the
elfmodule no longer exists.This is also the first steps towards #745, although there is still much work to be done regarding this issue.