Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we will update the flash size in the following order:
--flash-size
argsave-image
cant)We have to pass
flasher
arround which is not ideal... I initially though of cfef334 but that results in lots of duplicated code.Tests
I generated an std template:
cargo generate esp-rs/esp-idf-template cargo
for S3 and with the default configurations. Updated the code to:When building this, we get the following elf:
When triying to flash it with
[email protected]
(installed a few days ago):When using this patch: