Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to the new release #182

Merged
merged 5 commits into from
Jan 26, 2024
Merged

Update to the new release #182

merged 5 commits into from
Jan 26, 2024

Conversation

ivmarkov
Copy link
Collaborator

No description provided.

SergioGasquez
SergioGasquez requested changes Jan 26, 2024
View reviewed changes
Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the MSRV is now 1.75 while in CI we use 1.71

@ivmarkov
Copy link
Collaborator Author

Seems like the MSRV is now 1.75 while in CI we use 1.71

Indeed. Shall we just remove the version string from there? This way it would be always compiled against the latest Rust version available?

@SergioGasquez
Copy link
Member

Indeed. Shall we just remove the version string from there? This way it would be always compiled against the latest Rust version available?

Yes, I think that would be better. Regarding 88d0ef7, the tag 1.5 already points to the latest patch release, so I would also recommend using 1.5 instead of the pointing to the latest "full" version

@ivmarkov
Copy link
Collaborator Author

Indeed. Shall we just remove the version string from there? This way it would be always compiled against the latest Rust version available?

Yes, I think that would be better. Regarding 88d0ef7, the tag 1.5 already points to the latest patch release, so I would also recommend using 1.5 instead of the pointing to the latest "full" version

Ok. I just copied from somewhere, but will revert.

@ivmarkov
Copy link
Collaborator Author

Indeed. Shall we just remove the version string from there? This way it would be always compiled against the latest Rust version available?

Yes, I think that would be better. Regarding 88d0ef7, the tag 1.5 already points to the latest patch release, so I would also recommend using 1.5 instead of the pointing to the latest "full" version

Ok. I just copied from somewhere, but will revert.

Reverted. You need to squash prior to merging.

@ivmarkov
Copy link
Collaborator Author

Sorry for the vfs hiccup - did not anticipate that. :) For now, I've enabled the vfs component in the cmake build. Next patch release of esp-idf-svc will have that addressed.

SergioGasquez
SergioGasquez approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for updating this!

@SergioGasquez SergioGasquez merged commit ae1f15a into master Jan 26, 2024
53 checks passed
@SergioGasquez SergioGasquez deleted the new-release branch January 26, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioGasquez SergioGasquez SergioGasquez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivmarkov @SergioGasquez