Fix: Properly complete HTTP response on error #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses the issue where the EspHttpServer does not handle errors correctly, causing the HTTP connection to hang indefinitely. The issue was due to the lack of a connection.complete() call when an error occurs. Fixes: esp-rs#328
|
Hm, I was under the impression that if we don't do it, the underlying C code does it anyway (i.e. send the response if it is not send yet)? But since you say it actually doesn't... thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses an issue where the EspHttpServer does not handle errors correctly, causing the HTTP connection to hang indefinitely. When an error is returned from a closure handling an HTTP request, the server logs the error but does not complete the response. As a result, the client hangs indefinitely, waiting for the response to be fully sent. This PR adds a call to
connection.complete()in the error handling code to ensure that the response is properly finalized.Fixes: #328