-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix WPS regression and cred conversion #379
Conversation
I'm not quite sure how it works, but some routers will send 64-byte access tokens instead of the passphrase. Until now, the code assumed that ssid / password are always 0-terminated, but it's actually possible for them to use the maximum length of 32/64. I had no success actually connecting to the Wifi using that token on the esp (it does work on other devices). I ended up setting |
I've delayed merging this for way too long, and now it has a conflict. :( (BTW: I've finally checked the (under-documented) ESP IDF Wifi API, and I confirm you are likely correct in the weird behavior w.r.t. SSID (and likely password) in that is is a null-terminated string except when it is full length). |
BTW, I'm worried that we might have other places to fix: specifically, the reverse conversion of native SSID into |
Fixes esp-rs#337 Also fixes the conversion of ssid/password in the config to no longer assume 0 termination - this lead to problems when routers send a 64 byte access token to us instead of a password
@ivmarkov rebased. |
Thank you! |
Fixes #337
Also fixes the conversion of ssid/password in the config to no longer assume 0 termination - this lead to problems when routers send a 64 byte access token to us instead of a password