Skip to content

Commit

Permalink
general feedback on all the commited stuff (#354)
Browse files Browse the repository at this point in the history
* mention sdkconfig options needed for spi phy

* remove unwrap

* revert unwrap
  • Loading branch information
Vollbrecht authored Jan 26, 2024
1 parent ccd5f23 commit 106cf0a
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
7 changes: 7 additions & 0 deletions examples/eth_spi_async.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
// To be able to use this example, you need to set the following in your sdkconfig.default file:
// CONFIG_ETH_SPI_ETHERNET_DM9051=y
// CONFIG_ETH_SPI_ETHERNET_W5500=y
// CONFIG_ETH_SPI_ETHERNET_KSZ8851SNL=y
// You only pick one of the three, depending on which chip you have on your board.
// Also adjust the EspEth::wrap call below to match your board's chip.

fn main() {
#[cfg(esp32)]
example::main().unwrap();
Expand Down
6 changes: 4 additions & 2 deletions examples/eventloop.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,13 @@ use esp_idf_sys::EspError;

use log::info;

fn main() {
fn main() -> Result<(), EspError> {
esp_idf_svc::sys::link_patches();
EspLogger::initialize_default();

run().unwrap();
run()?;

Ok(())
}

fn run() -> Result<(), EspError> {
Expand Down

0 comments on commit 106cf0a

Please sign in to comment.