Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add 2024-04-04 meeting notes #497

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Conversation

sam3k
Copy link
Contributor

@sam3k sam3k commented Apr 8, 2024

Closes #495


**Resolution:** We've agreed to accept this proposal but will omit `node` option at this time.

### [Change Request: Provide a way for rules to apply suggestions to other files](https://github.com/eslint/eslint/issues/17881)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fyi, I've removed the tsc-agenda label but maybe i shouldn't have since we table this conversation. Please let me know if I should add it back so we don't lose track of this issue. 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are going to try to handle this directly on the issue, so no need for the label at this point.


**Action Items:** @nzakas will work on the PR

### [feat: Support different names for code block languages](https://github.com/eslint/eslint-plugin-markdown/issues/245)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not able to remove the tsc-agenda label. Looks like I don't have the right permissions:

Screenshot 2024-04-08 at 5 26 17 AM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sam3k can you try again? You should have access now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fasttime it works now! Thank you!

nzakas
nzakas previously approved these changes Apr 8, 2024
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would like @fasttime to approve before merging.

notes/2024/2024-04-04.md Outdated Show resolved Hide resolved
Co-authored-by: Francesco Trotta <[email protected]>
Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fasttime fasttime merged commit 823c28a into eslint:main Apr 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TSC meeting 04-April-2024
3 participants