Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set web app title for apple mobile #607

Merged

Conversation

chenxsan
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request?

Optimize the display of ESLint web app on iOS (see the second icon of the following screenshot).

  1. Currently it would show the first icon in the following screenshot, i.e., a black background due to the transparent pixels of png file.
  2. Currently it would show a default title of the web site, i.e., Find and fix problems in your JavaScript code - ESLint - Pluggable JavaScript Linter. Sure users can modify it themselves, but I reckon we can have a better default title.

image

What changes did you make? (Give an overview)

  1. update the apple-touch-icon.png file with a white background color
  2. set meta for apple-mobile-web-app-title so the default web app title would be ESLint instead of Find and fix problems in your JavaScript code - ESLint - Pluggable JavaScript Linter on iOS.

Related Issues

Is there anything you'd like reviewers to focus on?

Copy link

netlify bot commented Jul 25, 2024

Deploy Preview for new-eslint ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 84bafa8
🔍 Latest deploy log https://app.netlify.com/sites/new-eslint/deploys/66a2376c3c3491000897a43e
😎 Deploy Preview https://deploy-preview-607--new-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 25, 2024

Deploy Preview for ja-eslint ready!

Name Link
🔨 Latest commit 84bafa8
🔍 Latest deploy log https://app.netlify.com/sites/ja-eslint/deploys/66a2376c9403750008a080d7
😎 Deploy Preview https://deploy-preview-607--ja-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 25, 2024

Deploy Preview for es-eslint ready!

Name Link
🔨 Latest commit 84bafa8
🔍 Latest deploy log https://app.netlify.com/sites/es-eslint/deploys/66a2376cd563720008e7aac0
😎 Deploy Preview https://deploy-preview-607--es-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 25, 2024

Deploy Preview for zh-hans-eslint ready!

Name Link
🔨 Latest commit 84bafa8
🔍 Latest deploy log https://app.netlify.com/sites/zh-hans-eslint/deploys/66a2376c23dfae000803646c
😎 Deploy Preview https://deploy-preview-607--zh-hans-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 25, 2024

Deploy Preview for hi-eslint ready!

Name Link
🔨 Latest commit 84bafa8
🔍 Latest deploy log https://app.netlify.com/sites/hi-eslint/deploys/66a2376ce7360000081625ef
😎 Deploy Preview https://deploy-preview-607--hi-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 25, 2024

Deploy Preview for fr-eslint ready!

Name Link
🔨 Latest commit 84bafa8
🔍 Latest deploy log https://app.netlify.com/sites/fr-eslint/deploys/66a2376cacee500008e0db20
😎 Deploy Preview https://deploy-preview-607--fr-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 25, 2024

Deploy Preview for pt-br-eslint ready!

Name Link
🔨 Latest commit 84bafa8
🔍 Latest deploy log https://app.netlify.com/sites/pt-br-eslint/deploys/66a2376cb061b9000875f678
😎 Deploy Preview https://deploy-preview-607--pt-br-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 25, 2024

Deploy Preview for de-eslint ready!

Name Link
🔨 Latest commit 84bafa8
🔍 Latest deploy log https://app.netlify.com/sites/de-eslint/deploys/66a2376c5994e900082d48ee
😎 Deploy Preview https://deploy-preview-607--de-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nzakas nzakas merged commit 23ae076 into eslint:main Jul 25, 2024
37 checks passed
@chenxsan chenxsan deleted the feat/set-title-for-apple-mobile-web-app branch July 26, 2024 00:22
zhangenming pushed a commit to zhangenming/eslint.org that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants