Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix search input stylings #603

Merged
merged 1 commit into from
Jul 13, 2024
Merged

fix: fix search input stylings #603

merged 1 commit into from
Jul 13, 2024

Conversation

amareshsm
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request?

What changes did you make? (Give an overview)

Changes made:

  1. Fixed the search text overlapping with the close icon
  2. Correct the position of the close icon
  3. Adjusted the positioning of the search results dropdown
Before After
image image

similar to eslint/eslint#18682

Related Issues

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot bot added the bug Something isn't working label Jul 13, 2024
Copy link

netlify bot commented Jul 13, 2024

Deploy Preview for ja-eslint ready!

Name Link
🔨 Latest commit 349a9b8
🔍 Latest deploy log https://app.netlify.com/sites/ja-eslint/deploys/669288bfeb7b600008b0e17d
😎 Deploy Preview https://deploy-preview-603--ja-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 13, 2024

Deploy Preview for es-eslint ready!

Name Link
🔨 Latest commit 349a9b8
🔍 Latest deploy log https://app.netlify.com/sites/es-eslint/deploys/669288bfe981f80008f6eacb
😎 Deploy Preview https://deploy-preview-603--es-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 13, 2024

Deploy Preview for zh-hans-eslint ready!

Name Link
🔨 Latest commit 349a9b8
🔍 Latest deploy log https://app.netlify.com/sites/zh-hans-eslint/deploys/669288bf567964000896f00e
😎 Deploy Preview https://deploy-preview-603--zh-hans-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 13, 2024

Deploy Preview for pt-br-eslint ready!

Name Link
🔨 Latest commit 349a9b8
🔍 Latest deploy log https://app.netlify.com/sites/pt-br-eslint/deploys/669288bf993b7c0008b784a4
😎 Deploy Preview https://deploy-preview-603--pt-br-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 13, 2024

Deploy Preview for fr-eslint ready!

Name Link
🔨 Latest commit 349a9b8
🔍 Latest deploy log https://app.netlify.com/sites/fr-eslint/deploys/669288bfc9a2210008f3139f
😎 Deploy Preview https://deploy-preview-603--fr-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 13, 2024

Deploy Preview for de-eslint ready!

Name Link
🔨 Latest commit 349a9b8
🔍 Latest deploy log https://app.netlify.com/sites/de-eslint/deploys/669288bf5b723b000825be34
😎 Deploy Preview https://deploy-preview-603--de-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 13, 2024

Deploy Preview for hi-eslint ready!

Name Link
🔨 Latest commit 349a9b8
🔍 Latest deploy log https://app.netlify.com/sites/hi-eslint/deploys/669288bf2d827800089a9159
😎 Deploy Preview https://deploy-preview-603--hi-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 13, 2024

Deploy Preview for new-eslint ready!

Name Link
🔨 Latest commit 349a9b8
🔍 Latest deploy log https://app.netlify.com/sites/new-eslint/deploys/669288bf777f7b0008637a8d
😎 Deploy Preview https://deploy-preview-603--new-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 619a384 into main Jul 13, 2024
37 checks passed
@mdjermanovic mdjermanovic deleted the fix-search-styling branch July 13, 2024 14:50
zhangenming pushed a commit to zhangenming/eslint.org that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants