Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Powered by Algolia label to the search #595

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

amareshsm
Copy link
Member

@amareshsm amareshsm commented Jun 28, 2024

Prerequisites checklist

What is the purpose of this pull request?

Add Powered by Algolia label to the search

What changes did you make? (Give an overview)

Added powered by Algolia label under the search box
image

image

Related Issues

eslint/eslint#18620

Is there anything you'd like reviewers to focus on?

Need to verify that the changes work correctly across all device screen sizes.

Copy link

netlify bot commented Jun 28, 2024

Deploy Preview for es-eslint ready!

Name Link
🔨 Latest commit 91470f2
🔍 Latest deploy log https://app.netlify.com/sites/es-eslint/deploys/6686f402d937750008e78953
😎 Deploy Preview https://deploy-preview-595--es-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 28, 2024

Deploy Preview for ja-eslint ready!

Name Link
🔨 Latest commit 91470f2
🔍 Latest deploy log https://app.netlify.com/sites/ja-eslint/deploys/6686f40282deb600083191d7
😎 Deploy Preview https://deploy-preview-595--ja-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 28, 2024

Deploy Preview for new-eslint ready!

Name Link
🔨 Latest commit 91470f2
🔍 Latest deploy log https://app.netlify.com/sites/new-eslint/deploys/6686f4021c7f2c0009fb1a43
😎 Deploy Preview https://deploy-preview-595--new-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 28, 2024

Deploy Preview for zh-hans-eslint ready!

Name Link
🔨 Latest commit 91470f2
🔍 Latest deploy log https://app.netlify.com/sites/zh-hans-eslint/deploys/6686f4024e9dfc000982bde7
😎 Deploy Preview https://deploy-preview-595--zh-hans-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 28, 2024

Deploy Preview for fr-eslint ready!

Name Link
🔨 Latest commit 91470f2
🔍 Latest deploy log https://app.netlify.com/sites/fr-eslint/deploys/6686f40221664a000827a27f
😎 Deploy Preview https://deploy-preview-595--fr-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 28, 2024

Deploy Preview for hi-eslint ready!

Name Link
🔨 Latest commit 91470f2
🔍 Latest deploy log https://app.netlify.com/sites/hi-eslint/deploys/6686f402568d0700086fe819
😎 Deploy Preview https://deploy-preview-595--hi-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 28, 2024

Deploy Preview for de-eslint ready!

Name Link
🔨 Latest commit 91470f2
🔍 Latest deploy log https://app.netlify.com/sites/de-eslint/deploys/6686f40220d01300083e5929
😎 Deploy Preview https://deploy-preview-595--de-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 28, 2024

Deploy Preview for pt-br-eslint ready!

Name Link
🔨 Latest commit 91470f2
🔍 Latest deploy log https://app.netlify.com/sites/pt-br-eslint/deploys/6686f402fe2aa600075a0d8a
😎 Deploy Preview https://deploy-preview-595--pt-br-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nzakas
Copy link
Member

nzakas commented Jun 28, 2024

Screenshot 2024-06-28 at 17-05-19 News and Updates - ESLint - Pluggable JavaScript Linter

Feedback:

  1. The color of the Algolia logo and text looks pretty bad in both light and dark themes. Can we just have it be the same color as the "Powered by"?
  2. The baseline of the word "Algolia" is slightly higher than "Powered by", making it look broken. Can we get that baseline to match?

@nzakas
Copy link
Member

nzakas commented Jul 3, 2024

@amareshsm are you still working on this? If not, I can take it over. We'd like to get this updated and published ASAP.

@amareshsm
Copy link
Member Author

Screenshot 2024-06-28 at 17-05-19 News and Updates - ESLint - Pluggable JavaScript Linter

Feedback:

  1. The color of the Algolia logo and text looks pretty bad in both light and dark themes. Can we just have it be the same color as the "Powered by"?
  2. The baseline of the word "Algolia" is slightly higher than "Powered by", making it look broken. Can we get that baseline to match?

changes done. I have updated the description with the latest screenshots.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nzakas nzakas merged commit 1c6b197 into main Jul 5, 2024
37 checks passed
@nzakas nzakas deleted the add-powered-by-algolia branch July 5, 2024 14:47
zhangenming pushed a commit to zhangenming/eslint.org that referenced this pull request Jul 26, 2024
* chore: Add Powered by Algolia label to the search

* update style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants