Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed infinite flicker #553

Merged
merged 8 commits into from
Jun 30, 2024
Merged

fix: Fixed infinite flicker #553

merged 8 commits into from
Jun 30, 2024

Conversation

amareshsm
Copy link
Member

@amareshsm amareshsm commented Apr 14, 2024

Prerequisites checklist

What is the purpose of this pull request?

What changes did you make? (Give an overview)

fixes #551

Related Issues

#551

Is there anything you'd like reviewers to focus on?

I have mostly checked all the existing functionalities, but need to verify again to ensure that this change does not impact them.

@eslint-github-bot eslint-github-bot bot added the bug Something isn't working label Apr 14, 2024
Copy link

netlify bot commented Apr 14, 2024

Deploy Preview for es-eslint ready!

Name Link
🔨 Latest commit 07a0ae7
🔍 Latest deploy log https://app.netlify.com/sites/es-eslint/deploys/6675e673608119000860a062
😎 Deploy Preview https://deploy-preview-553--es-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 14, 2024

Deploy Preview for zh-hans-eslint ready!

Name Link
🔨 Latest commit 07a0ae7
🔍 Latest deploy log https://app.netlify.com/sites/zh-hans-eslint/deploys/6675e6734feae80008f29efb
😎 Deploy Preview https://deploy-preview-553--zh-hans-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 14, 2024

Deploy Preview for new-eslint ready!

Name Link
🔨 Latest commit 07a0ae7
🔍 Latest deploy log https://app.netlify.com/sites/new-eslint/deploys/6675e6730235b900083ac60f
😎 Deploy Preview https://deploy-preview-553--new-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 14, 2024

Deploy Preview for ja-eslint ready!

Name Link
🔨 Latest commit 07a0ae7
🔍 Latest deploy log https://app.netlify.com/sites/ja-eslint/deploys/6675e6734fc7f500080f1482
😎 Deploy Preview https://deploy-preview-553--ja-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 14, 2024

Deploy Preview for de-eslint ready!

Name Link
🔨 Latest commit 07a0ae7
🔍 Latest deploy log https://app.netlify.com/sites/de-eslint/deploys/6675e673850bb00008d1c34b
😎 Deploy Preview https://deploy-preview-553--de-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 14, 2024

Deploy Preview for hi-eslint ready!

Name Link
🔨 Latest commit 07a0ae7
🔍 Latest deploy log https://app.netlify.com/sites/hi-eslint/deploys/6675e673cd502500093a8385
😎 Deploy Preview https://deploy-preview-553--hi-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 14, 2024

Deploy Preview for fr-eslint ready!

Name Link
🔨 Latest commit 07a0ae7
🔍 Latest deploy log https://app.netlify.com/sites/fr-eslint/deploys/6675e673d903000008424568
😎 Deploy Preview https://deploy-preview-553--fr-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 14, 2024

Deploy Preview for pt-br-eslint ready!

Name Link
🔨 Latest commit 07a0ae7
🔍 Latest deploy log https://app.netlify.com/sites/pt-br-eslint/deploys/6675e673c7822000081c2531
😎 Deploy Preview https://deploy-preview-553--pt-br-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amareshsm amareshsm marked this pull request as draft April 14, 2024 21:34
@nzakas
Copy link
Member

nzakas commented Apr 25, 2024

Is this ready for review? We generally don't review drafts, so if you'd like feedback from the team, please click "Ready for Review"

@nzakas
Copy link
Member

nzakas commented May 9, 2024

Ping @amareshsm

@snitin315
Copy link
Contributor

@amareshsm Are you still working on it?

@amareshsm amareshsm marked this pull request as ready for review June 21, 2024 20:50
@amareshsm
Copy link
Member Author

@amareshsm Are you still working on it?

PR is ready for review.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would like @snitin315 to take a look before merging.

Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@snitin315 snitin315 merged commit 91f7508 into main Jun 30, 2024
37 checks passed
@snitin315 snitin315 deleted the fix-infinite-flicker branch June 30, 2024 04:20
zhangenming pushed a commit to zhangenming/eslint.org that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Bug: [playground] click fix button would cause Infinite flicker.(When quickly clicking multiple fixes)
3 participants