New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add disable rule button in playground messages #546

Merged

nzakas merged 5 commits into eslint:main from zhangenming:zhangenming/patch-81245

Aug 7, 2024

Contributor

zhangenming commented Apr 8, 2024 •

edited

Loading

Prerequisites checklist

[-] I have read the contributing guidelines.

What is the purpose of this pull request?

we can Disabled an rule quickly.

What changes did you make? (Give an overview)

Related Issues

fixes #548

Is there anything you'd like reviewers to focus on?

The css style is a little newbie not perfect sorry

eslint-github-bot bot added the feature label

linux-foundation-easycla bot commented Apr 8, 2024 •

edited

Loading

The committers listed above are authorized under a signed CLA.

✅ login: zhangenming (5cef364, cac9d51, 3dce19d, 5ace9cc, 63ed6e3)

netlify bot commented Apr 8, 2024 •

edited

Loading

✅ Deploy Preview for fr-eslint ready!

Name	Link
🔨 Latest commit	`5ace9cc`
🔍 Latest deploy log	https://app.netlify.com/sites/fr-eslint/deploys/66a999162575580008cadce1
😎 Deploy Preview	https://deploy-preview-546--fr-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Apr 8, 2024 •

edited

Loading

✅ Deploy Preview for es-eslint ready!

Name	Link
🔨 Latest commit	`5ace9cc`
🔍 Latest deploy log	https://app.netlify.com/sites/es-eslint/deploys/66a9991670072b0008a09754
😎 Deploy Preview	https://deploy-preview-546--es-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Apr 8, 2024 •

edited

Loading

✅ Deploy Preview for zh-hans-eslint ready!

Name	Link
🔨 Latest commit	`5ace9cc`
🔍 Latest deploy log	https://app.netlify.com/sites/zh-hans-eslint/deploys/66a999163daad60008cb6f2a
😎 Deploy Preview	https://deploy-preview-546--zh-hans-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Apr 8, 2024 •

edited

Loading

✅ Deploy Preview for pt-br-eslint ready!

Name	Link
🔨 Latest commit	`f3215ba`
🔍 Latest deploy log	https://app.netlify.com/sites/pt-br-eslint/deploys/6613f10e8897e20007281d01
😎 Deploy Preview	https://deploy-preview-546--pt-br-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Apr 8, 2024 •

edited

Loading

✅ Deploy Preview for ja-eslint ready!

Name	Link
🔨 Latest commit	`f3215ba`
🔍 Latest deploy log	https://app.netlify.com/sites/ja-eslint/deploys/6613f10e4e0c880007d318ba
😎 Deploy Preview	https://deploy-preview-546--ja-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Apr 8, 2024 •

edited

Loading

✅ Deploy Preview for de-eslint ready!

Name	Link
🔨 Latest commit	`f3215ba`
🔍 Latest deploy log	https://app.netlify.com/sites/de-eslint/deploys/6613f10e8897e20007281d03
😎 Deploy Preview	https://deploy-preview-546--de-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Apr 8, 2024 •

edited

Loading

✅ Deploy Preview for hi-eslint ready!

Name	Link
🔨 Latest commit	`5ace9cc`
🔍 Latest deploy log	https://app.netlify.com/sites/hi-eslint/deploys/66a99916c5c5b0000885fd8c
😎 Deploy Preview	https://deploy-preview-546--hi-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Apr 8, 2024 •

edited

Loading

✅ Deploy Preview for new-eslint ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`5ace9cc`
🔍 Latest deploy log	https://app.netlify.com/sites/new-eslint/deploys/66a99916c457fc0007bbb3d3
😎 Deploy Preview	https://deploy-preview-546--new-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Apr 8, 2024 •

edited

Loading

✅ Deploy Preview for ja-eslint ready!

Name	Link
🔨 Latest commit	`5ace9cc`
🔍 Latest deploy log	https://app.netlify.com/sites/ja-eslint/deploys/66a99916c1fc330008e28623
😎 Deploy Preview	https://deploy-preview-546--ja-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Apr 8, 2024 •

edited

Loading

✅ Deploy Preview for de-eslint ready!

Name	Link
🔨 Latest commit	`5ace9cc`
🔍 Latest deploy log	https://app.netlify.com/sites/de-eslint/deploys/66a99916894a4000083166e9
😎 Deploy Preview	https://deploy-preview-546--de-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Apr 8, 2024 •

edited

Loading

✅ Deploy Preview for pt-br-eslint ready!

Name	Link
🔨 Latest commit	`5ace9cc`
🔍 Latest deploy log	https://app.netlify.com/sites/pt-br-eslint/deploys/66a99916b3afdc000836f7f7
😎 Deploy Preview	https://deploy-preview-546--pt-br-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Member

amareshsm commented Apr 8, 2024

@zhangenming pls create an issue explaining what problem you are trying to solve and the solution you would like to implement. ESlint team will triage the issue and mark it as accepted if the team agrees.

amareshsm added triage and removed triage labels

zhangenming changed the title ~~feat: alert item add Disabled button.~~ feat: [playground]alert item add Disabled button.

nzakas reviewed

View reviewed changes

Member

nzakas left a comment

This looks like it could be useful, but I'd like some other reviews from @eslint/eslint-team before merging.

src/playground/components/Alert.js Outdated Show resolved Hide resolved

amareshsm reviewed

View reviewed changes

src/playground/components/Alert.js Outdated Show resolved Hide resolved

amareshsm reviewed

View reviewed changes

src/playground/components/Alert.js Outdated Show resolved Hide resolved

amareshsm added the accepted label

Member

amareshsm commented Jul 15, 2024

@zhangenming Are you still working on this?

amareshsm reviewed

View reviewed changes

Member

amareshsm left a comment

Pls resolve conflicts as well.

github-actions bot added the translation label

zhangenming force-pushed the zhangenming/patch-81245 branch 2 times, most recently from f176019 to a84a3a8 Compare

July 26, 2024 02:03


          feat: [playground]alert item add Disabled button.

5cef364

zhangenming force-pushed the zhangenming/patch-81245 branch from a84a3a8 to 5cef364 Compare

July 26, 2024 02:05


          npm run fmt

63ed6e3

zhangenming requested a review from amareshsm

July 26, 2024 02:12

amareshsm reviewed

View reviewed changes

Member

amareshsm left a comment

Currently the UI looks like the below image

Add the display: flex property to the alert__actions class to align the fix and disable buttons on the same line as shown in the below image.

zhangenming added 2 commits

July 29, 2024 10:36

css

cac9d51

css

3dce19d

zhangenming requested a review from amareshsm

July 30, 2024 01:47

amareshsm reviewed

View reviewed changes

Member

amareshsm left a comment

I checked the preview and clicked on "disable" for the quotes rule. After clicking the disable button in the right panel, the rule was removed. However, despite clicking disable, the error is still displayed, and the disable option is still shown in the UI.

'm not sure how you are implementing the disable behavior. Could you please brief?

Screen.Recording.2024-07-31.at.12.24.22.AM.mov

Contributor Author

zhangenming commented Jul 31, 2024 •

edited

Loading

Just delete this line because of his influence

The idea is to delete related options from the configuration list(rulesWithInvalidConfigs)

fix

5ace9cc

Contributor Author

zhangenming commented Jul 31, 2024

I added a judgment to handle this situation
The button is not displayed in this case

zhangenming requested a review from amareshsm

August 1, 2024 03:22

amareshsm approved these changes

View reviewed changes

Member

amareshsm left a comment

Thanks, LGTM. Leaving it open in case anyone else wants to review before merging.

harish-sethuraman approved these changes

View reviewed changes

Member

harish-sethuraman left a comment •

edited

Loading

LGTM. Would like someone from @eslint/eslint-tsc to verify if this was intended behaviour.

observations:

when a rule is selected through dropdown the disable button is shown
when the button is clicked to disable then the rule is removed from list of rules
inline enabling of lint rules doesn't pop disable button

fasttime changed the title ~~feat: [playground]alert item add Disabled button.~~ feat: add disable rule button in playground messages

fasttime approved these changes

View reviewed changes

Member

fasttime left a comment

LGTM. Leaving open for @nzakas to review.

nzakas approved these changes

View reviewed changes

Member

nzakas left a comment

LGTM.

@harish-sethuraman confirmed. This is the intended behavior.

nzakas added the contributor pool label

nzakas merged commit 64c1a1e into eslint:main

37 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted contributor pool feature translation