feat: add transform for v9 migration #29

snitin315 · 2024-05-22T12:39:48Z

Fix #25

nzakas

Thanks, this looks like a great start. Some overall comments:

I think we should call this v9-rule-migration to make it clear that this relates only to rules.
It looks like we are missing getScope(), markVariableAsUsed(), and getAncestors()
For things like sourceCode, is it possible to add a variable declaration for const sourceCode = context.sourceCode ?? context.getSourceCode() immediately inside the create() method and then replace all instances of context.getSourceCode() with that variable?

tests/lib/v9-migration/v9-migration.js

snitin315 · 2024-05-26T13:37:46Z

@nzakas I've addressed your feedback. PTAL

nzakas

Looking better, I think we're close. Just a few notes.

tests/utils/index.js

tests/lib/v9-rule-migration/v9-rule-migration.js

nzakas

Nice! This looks really good.

Would like another review before merging.

tests/lib/v9-rule-migration/v9-rule-migration.js

aladdin-add · 2024-06-04T02:30:42Z

tests/lib/v9-rule-migration/v9-rule-migration.js

+const v9MigrationTransform = require("../../../lib/v9-rule-migration/v9-rule-migration");
+
+describe("v9 migration transform", () => {
+    it("should migrate deprecated context methods to new properties", async () => {


can you also add a test that the vars were defined outside (it's more commonly used to avoid repeating), something like:

module.exports = { create(context) { const sourceCode = context.getSourceCode(); const cwd = context.getCwd(); const filename = context.getFilename(); const physicalFilename = context.getPhysicalFilename(); return { Program(node) { //.... }, }; } };

aladdin-add · 2024-06-04T03:16:40Z

I've tried running it to eslint-plugin-n v15.0.0, but got the error:

node ../eslint-transforms/bin/eslint-transforms.js v9-rule-migration ./lib
Processing 67 files... 
Spawning 7 workers...
Sending 10 files to free worker...
Sending 10 files to free worker...
Sending 10 files to free worker...
Sending 10 files to free worker...
Sending 10 files to free worker...
Sending 10 files to free worker...
Sending 7 files to free worker...
 ERR lib/util/check-unsupported-builtins.js Transformation error (Cannot read properties of null (reading 'node'))
TypeError: Cannot read properties of null (reading 'node')
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:76:27)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at NodePath.<anonymous> (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:226:44)
    at NodePath.<anonymous> (/Users/weiran/repo/github/eslint-transforms/node_modules/jscodeshift/src/collections/Node.js:142:47)
    at /Users/weiran/repo/github/eslint-transforms/node_modules/jscodeshift/src/Collection.js:75:36
    at Array.forEach (<anonymous>)
    at Collection.forEach (/Users/weiran/repo/github/eslint-transforms/node_modules/jscodeshift/src/Collection.js:74:18)
    at Collection.replaceWith (/Users/weiran/repo/github/eslint-transforms/node_modules/jscodeshift/src/collections/Node.js:140:17)
    at Collection.replaceWith (/Users/weiran/repo/github/eslint-transforms/node_modules/jscodeshift/src/Collection.js:413:43)
    at module.exports (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:203:8)
 ERR lib/rules/no-path-concat.js Transformation error (Cannot read properties of undefined (reading 'name'))
TypeError: Cannot read properties of undefined (reading 'name')
    at NodePath.<anonymous> (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:228:56)
    at NodePath.<anonymous> (/Users/weiran/repo/github/eslint-transforms/node_modules/jscodeshift/src/collections/Node.js:142:47)
    at /Users/weiran/repo/github/eslint-transforms/node_modules/jscodeshift/src/Collection.js:75:36
    at Array.forEach (<anonymous>)
    at Collection.forEach (/Users/weiran/repo/github/eslint-transforms/node_modules/jscodeshift/src/Collection.js:74:18)
    at Collection.replaceWith (/Users/weiran/repo/github/eslint-transforms/node_modules/jscodeshift/src/collections/Node.js:140:17)
    at Collection.replaceWith (/Users/weiran/repo/github/eslint-transforms/node_modules/jscodeshift/src/Collection.js:413:43)
    at module.exports (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:203:8)
 ERR lib/util/visit-require.js Transformation error (Cannot read properties of undefined (reading 'name'))
TypeError: Cannot read properties of undefined (reading 'name')
    at NodePath.<anonymous> (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:228:56)
    at NodePath.<anonymous> (/Users/weiran/repo/github/eslint-transforms/node_modules/jscodeshift/src/collections/Node.js:142:47)
    at /Users/weiran/repo/github/eslint-transforms/node_modules/jscodeshift/src/Collection.js:75:36
    at Array.forEach (<anonymous>)
    at Collection.forEach (/Users/weiran/repo/github/eslint-transforms/node_modules/jscodeshift/src/Collection.js:74:18)
    at Collection.replaceWith (/Users/weiran/repo/github/eslint-transforms/node_modules/jscodeshift/src/collections/Node.js:140:17)
    at Collection.replaceWith (/Users/weiran/repo/github/eslint-transforms/node_modules/jscodeshift/src/Collection.js:413:43)
    at module.exports (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:203:8)
 ERR lib/rules/no-deprecated-api.js Transformation error (Cannot read properties of undefined (reading 'name'))
TypeError: Cannot read properties of undefined (reading 'name')
    at NodePath.<anonymous> (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:228:56)
    at NodePath.<anonymous> (/Users/weiran/repo/github/eslint-transforms/node_modules/jscodeshift/src/collections/Node.js:142:47)
    at /Users/weiran/repo/github/eslint-transforms/node_modules/jscodeshift/src/Collection.js:75:36
    at Array.forEach (<anonymous>)
    at Collection.forEach (/Users/weiran/repo/github/eslint-transforms/node_modules/jscodeshift/src/Collection.js:74:18)
    at Collection.replaceWith (/Users/weiran/repo/github/eslint-transforms/node_modules/jscodeshift/src/collections/Node.js:140:17)
    at Collection.replaceWith (/Users/weiran/repo/github/eslint-transforms/node_modules/jscodeshift/src/Collection.js:413:43)
    at module.exports (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:203:8)
 ERR lib/util/check-prefer-global.js Transformation error (Cannot read properties of null (reading 'node'))
TypeError: Cannot read properties of null (reading 'node')
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:76:27)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at NodePath.<anonymous> (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:226:44)
    at NodePath.<anonymous> (/Users/weiran/repo/github/eslint-transforms/node_modules/jscodeshift/src/collections/Node.js:142:47)
    at /Users/weiran/repo/github/eslint-transforms/node_modules/jscodeshift/src/Collection.js:75:36
    at Array.forEach (<anonymous>)
    at Collection.forEach (/Users/weiran/repo/github/eslint-transforms/node_modules/jscodeshift/src/Collection.js:74:18)
    at Collection.replaceWith (/Users/weiran/repo/github/eslint-transforms/node_modules/jscodeshift/src/collections/Node.js:140:17)
    at Collection.replaceWith (/Users/weiran/repo/github/eslint-transforms/node_modules/jscodeshift/src/Collection.js:413:43)
    at module.exports (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:203:8)
 ERR lib/rules/no-unsupported-features/es-syntax.js Transformation error (Cannot read properties of null (reading 'node'))
TypeError: Cannot read properties of null (reading 'node')
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:76:27)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at getParentObjectMethod (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:81:12)
    at NodePath.<anonymous> (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:226:44)
    at NodePath.<anonymous> (/Users/weiran/repo/github/eslint-transforms/node_modules/jscodeshift/src/collections/Node.js:142:47)
    at /Users/weiran/repo/github/eslint-transforms/node_modules/jscodeshift/src/Collection.js:75:36
    at Array.forEach (<anonymous>)
    at Collection.forEach (/Users/weiran/repo/github/eslint-transforms/node_modules/jscodeshift/src/Collection.js:74:18)
    at Collection.replaceWith (/Users/weiran/repo/github/eslint-transforms/node_modules/jscodeshift/src/collections/Node.js:140:17)
    at Collection.replaceWith (/Users/weiran/repo/github/eslint-transforms/node_modules/jscodeshift/src/Collection.js:413:43)
    at module.exports (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:203:8)
 ERR lib/rules/prefer-promises/fs.js Transformation error (Cannot read properties of undefined (reading 'name'))
TypeError: Cannot read properties of undefined (reading 'name')
    at NodePath.<anonymous> (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:228:56)
    at NodePath.<anonymous> (/Users/weiran/repo/github/eslint-transforms/node_modules/jscodeshift/src/collections/Node.js:142:47)
    at /Users/weiran/repo/github/eslint-transforms/node_modules/jscodeshift/src/Collection.js:75:36
    at Array.forEach (<anonymous>)
    at Collection.forEach (/Users/weiran/repo/github/eslint-transforms/node_modules/jscodeshift/src/Collection.js:74:18)
    at Collection.replaceWith (/Users/weiran/repo/github/eslint-transforms/node_modules/jscodeshift/src/collections/Node.js:140:17)
    at Collection.replaceWith (/Users/weiran/repo/github/eslint-transforms/node_modules/jscodeshift/src/Collection.js:413:43)
    at module.exports (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:203:8)
 ERR lib/rules/prefer-promises/dns.js Transformation error (Cannot read properties of undefined (reading 'name'))
TypeError: Cannot read properties of undefined (reading 'name')
    at NodePath.<anonymous> (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:228:56)
    at NodePath.<anonymous> (/Users/weiran/repo/github/eslint-transforms/node_modules/jscodeshift/src/collections/Node.js:142:47)
    at /Users/weiran/repo/github/eslint-transforms/node_modules/jscodeshift/src/Collection.js:75:36
    at Array.forEach (<anonymous>)
    at Collection.forEach (/Users/weiran/repo/github/eslint-transforms/node_modules/jscodeshift/src/Collection.js:74:18)
    at Collection.replaceWith (/Users/weiran/repo/github/eslint-transforms/node_modules/jscodeshift/src/collections/Node.js:140:17)
    at Collection.replaceWith (/Users/weiran/repo/github/eslint-transforms/node_modules/jscodeshift/src/Collection.js:413:43)
    at module.exports (/Users/weiran/repo/github/eslint-transforms/lib/v9-rule-migration/v9-rule-migration.js:203:8)
All done. 
Results: 
8 errors
41 unmodified
0 skipped
18 ok
Time elapsed: 2.956seconds

snitin315 · 2024-06-05T02:59:22Z

I've tried running it to eslint-plugin-n v15.0.0, but got the error:

Looking into it.

snitin315 · 2024-06-06T01:22:13Z

I've tried running it to eslint-plugin-n v15.0.0, but got the error:

@aladdin-add Fixed 👍🏻, it was failing when the methods were in some helper utils instead of being directly under the create() method.

aladdin-add

LGTM, thanks! 💯

feat: add transform for v9 migration

24b6100

eslint-github-bot bot added the feature label May 22, 2024

snitin315 added 3 commits May 22, 2024 19:44

chore: add test cases

b16fd61

chore: remove unwanted changes

c61b72f

chore: fix tests on windows

0641788

snitin315 marked this pull request as ready for review May 23, 2024 04:00

nzakas requested changes May 23, 2024

View reviewed changes

tests/lib/v9-migration/v9-migration.js Outdated Show resolved Hide resolved

feat: cover more cases

f412c0b

snitin315 force-pushed the v9-codemod branch from 35130da to f412c0b Compare May 25, 2024 09:41

nzakas requested changes May 27, 2024

View reviewed changes

snitin315 added 2 commits June 1, 2024 16:14

fix: cover more cases

67acc38

docs: update

795992f

aladdin-add self-requested a review June 3, 2024 09:14

nzakas previously approved these changes Jun 3, 2024

View reviewed changes

aladdin-add reviewed Jun 4, 2024

View reviewed changes

fix: cover more edge cases

955d26a

snitin315 dismissed nzakas’s stale review via 955d26a June 6, 2024 01:18

aladdin-add approved these changes Jun 6, 2024

View reviewed changes

aladdin-add merged commit 528b94f into main Jun 6, 2024
9 checks passed

aladdin-add deleted the v9-codemod branch June 6, 2024 01:43

github-actions bot mentioned this pull request Jun 6, 2024

chore: release 3.0.0 #21

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add transform for v9 migration #29

feat: add transform for v9 migration #29

snitin315 commented May 22, 2024 •

edited

Loading

nzakas left a comment

snitin315 commented May 26, 2024

nzakas left a comment

nzakas left a comment

aladdin-add Jun 4, 2024

snitin315 Jun 6, 2024

aladdin-add commented Jun 4, 2024

snitin315 commented Jun 5, 2024

snitin315 commented Jun 6, 2024

aladdin-add left a comment

feat: add transform for v9 migration #29

feat: add transform for v9 migration #29

Conversation

snitin315 commented May 22, 2024 • edited Loading

nzakas left a comment

Choose a reason for hiding this comment

snitin315 commented May 26, 2024

nzakas left a comment

Choose a reason for hiding this comment

nzakas left a comment

Choose a reason for hiding this comment

aladdin-add Jun 4, 2024

Choose a reason for hiding this comment

snitin315 Jun 6, 2024

Choose a reason for hiding this comment

aladdin-add commented Jun 4, 2024

snitin315 commented Jun 5, 2024

snitin315 commented Jun 6, 2024

aladdin-add left a comment

Choose a reason for hiding this comment

snitin315 commented May 22, 2024 •

edited

Loading