Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Improve test coverage and runtime #24

Merged
merged 5 commits into from
Jan 25, 2024
Merged

FIX: Improve test coverage and runtime #24

merged 5 commits into from
Jan 25, 2024

Conversation

nocollier
Copy link
Member

This is a precursor to working on #20 and does not yet add quantitative checks to the operators.

@nocollier nocollier requested a review from mgrover1 as a code owner January 25, 2024 19:49
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5ea9997) 74.69% compared to head (5fd0876) 86.41%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #24       +/-   ##
===========================================
+ Coverage   74.69%   86.41%   +11.71%     
===========================================
  Files          10       10               
  Lines         743      714       -29     
===========================================
+ Hits          555      617       +62     
+ Misses        188       97       -91     
Flag Coverage Δ
unittests 86.41% <ø> (+11.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mgrover1 mgrover1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense - good idea cutting this down a bit

@nocollier nocollier merged commit 555eef3 into main Jan 25, 2024
15 checks passed
@nocollier nocollier deleted the tests branch January 25, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants