Skip to content

Customize desktop status bar / 自定义桌面底部信息栏#4152

Closed
SivanCola wants to merge 1 commit into
main-v2from
feature/status-bar-display-options
Closed

Customize desktop status bar / 自定义桌面底部信息栏#4152
SivanCola wants to merge 1 commit into
main-v2from
feature/status-bar-display-options

Conversation

@SivanCola

Copy link
Copy Markdown
Collaborator

Summary

  • Add a desktop status bar style setting for text or icon labels.
  • Add a collapsible status bar item editor with visibility toggles, arrow ordering, drag reordering, and insertion-line feedback.
  • Add a per-turn cost status item and clarify the cumulative item as session cost.

Verification

  • pnpm --dir desktop/frontend check:css
  • pnpm --dir desktop/frontend typecheck
  • go test -count=1 ./internal/config
  • go test -count=1 . from desktop
  • Browser verification: status bar shows 本次费用 and 会话费用, and the configurable item list renders correctly.

@SivanCola SivanCola requested a review from esengine as a code owner June 12, 2026 08:14
@github-actions github-actions Bot added v2 Go rewrite (1.x) — main-v2 branch, active development desktop Wails desktop app (desktop/**) config Configuration & setup (internal/config) labels Jun 12, 2026
@esengine

Copy link
Copy Markdown
Owner

Thanks — the implementation looks great and I'm happy to merge this. The status-bar item config is clean, the frontend STATUS_BAR_ITEM_IDS match the backend knownDesktopStatusBarItems set exactly (with mirror normalizers on both sides, so a stale config degrades gracefully), and splitting per-turn turn_cost from the cumulative session cost is a nice touch.

It just needs a rebase onto current main-v2. #4071 and #4151 landed after you opened this and moved the shared frontend files (App.tsx, bridge.ts, types.ts, useController.ts, locales/*, app_test.go), so GitHub now shows conflicts — the same quick rebase you did on #4151. The conflicts should be additive (both sides just appended new locale keys / bridge methods / types). Once CI is green again I'll merge.

Thanks for the steady stream of solid PRs.

@esengine

Copy link
Copy Markdown
Owner

I rebased this onto current main-v2 in #4188 so it can land — #4071 / #4151 / #4176 had moved the shared frontend files after you opened this, and the conflicts were blocking the merge. #4188 is entirely your work carried across with the conflicts resolved, and it credits you. I'll merge it once CI is green and close this in favour of it. Thanks again for the steady stream of solid PRs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

config Configuration & setup (internal/config) desktop Wails desktop app (desktop/**) v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants