You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks — the implementation looks great and I'm happy to merge this. The status-bar item config is clean, the frontend STATUS_BAR_ITEM_IDS match the backend knownDesktopStatusBarItems set exactly (with mirror normalizers on both sides, so a stale config degrades gracefully), and splitting per-turn turn_cost from the cumulative session cost is a nice touch.
It just needs a rebase onto current main-v2. #4071 and #4151 landed after you opened this and moved the shared frontend files (App.tsx, bridge.ts, types.ts, useController.ts, locales/*, app_test.go), so GitHub now shows conflicts — the same quick rebase you did on #4151. The conflicts should be additive (both sides just appended new locale keys / bridge methods / types). Once CI is green again I'll merge.
I rebased this onto current main-v2 in #4188 so it can land — #4071 / #4151 / #4176 had moved the shared frontend files after you opened this, and the conflicts were blocking the merge. #4188 is entirely your work carried across with the conflicts resolved, and it credits you. I'll merge it once CI is green and close this in favour of it. Thanks again for the steady stream of solid PRs!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
configConfiguration & setup (internal/config)desktopWails desktop app (desktop/**)v2Go rewrite (1.x) — main-v2 branch, active development
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
pnpm --dir desktop/frontend check:csspnpm --dir desktop/frontend typecheckgo test -count=1 ./internal/configgo test -count=1 .fromdesktop本次费用and会话费用, and the configurable item list renders correctly.