fix(desktop): make the frontend typecheck under TypeScript 6 (unblocks #3691)#3791
Merged
Conversation
@types/react 19 (bumped in #3690) tightened ref nullability and dropped the global JSX namespace, which TypeScript 6 enforces. Type the shared ref props as RefObject<T | null> (matching what useRef(null) returns), import the JSX namespace from react, and give the debounce useRef an explicit initial value. No behavior change; unblocks the typescript@6 bump (#3691).
github-actions
Bot
added
v2
SuMuxi66
pushed a commit
to SuMuxi66/DeepSeek-Reasonix
that referenced
this pull request
Jun 10, 2026
…e#3791) @types/react 19 (bumped in esengine#3690) tightened ref nullability and dropped the global JSX namespace, which TypeScript 6 enforces. Type the shared ref props as RefObject<T | null> (matching what useRef(null) returns), import the JSX namespace from react, and give the debounce useRef an explicit initial value. No behavior change; unblocks the typescript@6 bump (esengine#3691). Co-authored-by: reasonix <reasonix@deepseek.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks the TypeScript 6 bump (#3691). The
@types/react19 bump (#3690) tightened ref nullability and dropped the globalJSXnamespace; TypeScript 6 enforces both, so the frontend typecheck fails under #3691 even though it passes under 5.9.Fixes (no behavior change, all valid under the current TS 5.9 too):
AnchoredPopover/PromptShelf: shared ref props typedRefObject<T | null>to match whatuseRef(null)actually returns.WorkspacePanel: import theJSXnamespace fromreactinstead of relying on the removed global.Composer: give the debounceuseRefan explicitundefinedinitial value.Verified locally: with
typescript@6.0.3, the 12 errors #3691 hit are gone (only the wails-generated bindings, which CI generates, remain); under the locked TS 5.9 the changed files add no new errors. Once this lands, #3691 should go green on rebase.