fix(desktop): restore clipboard image paste / 修复桌面端剪贴板图片粘贴#3707
Merged
SivanCola merged 5 commits intoJun 10, 2026
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
github-actions
Bot
added
v2
SivanCola
changed the title
github-actions
Bot
added
agent
…image-paste # Conflicts: # internal/control/shell_test.go # internal/provider/anthropic/anthropic_test.go
…image-paste # Conflicts: # desktop/frontend/src/components/Composer.tsx
esengine
approved these changes
Jun 10, 2026
esengine
left a comment
esengine
left a comment
Owner
There was a problem hiding this comment.
Solid fix — the three-layer fallback (items merge → native clipboard read → keypress timer) is well thought out, with dedup so the layers never double-attach. Nice catch promoting the silent os.Chdir failure to a real error, and good workspace-root test coverage. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The composer only inspected e.clipboardData.files. In some desktop WebView clipboard states, Ctrl/Cmd+V provides an image hint or item but no files, and plain text is empty, so the textarea paste becomes a no-op with no visible attachment.
Verification