Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from ljharb:main #46

Merged
merged 12 commits into from
Feb 13, 2024
Merged

[pull] main from ljharb:main #46

merged 12 commits into from
Feb 13, 2024

Conversation

pull[bot]
Copy link

@pull pull bot commented Feb 3, 2024

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

…ssible

This reflects the ES2023+ convention of using eg "x is a String" rather than "Type(x) is String", and ends up being more performant, produces smaller bundles, improves TypeScript narrowing, and allows engines to optimize more typeof comparisons.
…ffer`, `is-typed-array`, `which-typed-array`
Copy link

codecov bot commented Feb 3, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e239ab2) 96.81% compared to head (d786558) 96.69%.

Files Patch % Lines
2018/GetSubstitution.js 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
- Coverage   96.81%   96.69%   -0.12%     
==========================================
  Files        1805     1809       +4     
  Lines       27222    26031    -1191     
  Branches     5854     5919      +65     
==========================================
- Hits        26354    25171    -1183     
+ Misses        868      860       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pull pull bot added the ⤵️ pull label Feb 3, 2024
@ljharb ljharb merged commit d786558 into es-shims:main Feb 13, 2024
319 of 322 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant