public_key: Add missing macros #9865
Conversation
CT Test Results 2 files 17 suites 4m 18s ⏱️ Results for commit 8445094. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
IngelaAndin
added
team:PS
IngelaAndin
force-pushed
the
ingela/public_key/macros/OTP-19644
branch
from
af8629b to
fd7eed4
Compare
IngelaAndin
force-pushed
the
ingela/public_key/macros/OTP-19644
branch
2 times, most recently
from
d7e729b to
64c3a55
Compare
IngelaAndin
force-pushed
the
ingela/public_key/macros/OTP-19644
branch
2 times, most recently
from
5b84b31 to
17a932a
Compare
|
|
IngelaAndin
force-pushed
the
ingela/public_key/macros/OTP-19644
branch
from
17a932a to
8445094
Compare
| get_asn1_module('FreshestCRL') -> 'PKIX1Implicit-2009'; | ||
| get_asn1_module('IssuingDistributionPoint') -> 'PKIX1Implicit-2009'; | ||
| get_asn1_module('GeneralNames') -> 'PKIX1Implicit-2009'; | ||
| get_asn1_module('Validity') -> 'PKIX1Implicit-2009'; |
There was a problem hiding this comment.
| get_asn1_module('Validity') -> 'PKIX1Implicit-2009'; | |
| get_asn1_module('Validity') -> 'PKIX1Explicit-2009'; |
| get_asn1_module('Certificate') -> 'PKIX1Explicit-2009'; | ||
| get_asn1_module('SubjectAltName') -> 'PKIX1Implicit-2009'; |
There was a problem hiding this comment.
So this would be nice: to be able to call public_key:der_encode('SubjectAltName', SANExtension). I use that to include a SubjectAltName extension in a CSR extensionRequest.
Unfortunately PKIX1Implicit-2009 does not define the necessary enc_SubjectAltName/2 function, so this fails with {:error, {:asn1, {{:undefined_type, :SubjectAltName}, ...}. There is enc_ext-SubjectAltName/2, though.
There seem to be some inconsistencies in this respect for various certificate extensions. For example, AuthorityKeyIdentifier and SubjectKeyIdentifier do expose enc_Xxx and dec_Xxx functions.
closes #9857