Skip to content

gh: Use renovate to update dependencies #9850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

garazdawi
Copy link
Contributor

This change moves github actions updating to renovate and adds monitoring of vendored dependencies as well as automatically providing the code needed for the update.

@garazdawi garazdawi requested a review from kikofernandez May 20, 2025 13:33
@garazdawi garazdawi self-assigned this May 20, 2025
@garazdawi garazdawi added the team:VM Assigned to OTP team VM label May 20, 2025
Copy link
Contributor

github-actions bot commented May 20, 2025

CT Test Results

    3 files    142 suites   49m 30s ⏱️
1 649 tests 1 591 ✅ 57 💤 1 ❌
2 372 runs  2 294 ✅ 77 💤 1 ❌

For more details on these failures, see this check.

Results for commit cdf958a.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@@ -76,24 +79,26 @@ incorporate them into to_chars.h.

Once done, update xcharconv_ryu.h.sha with the new sha. i.e.

echo "${STL_SHA}" > ${ERL_TOP}/erts/emulator/ryu/xcharconv_ryu.h.sha
echo "${STL_CHARCONV_SHA}" > ${ERL_TOP}/erts/emulator/ryu/xcharconv_ryu.h.sha
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the update-vendored-deps.sh is going to run the updates, then some script should do this update for the ${ERL_TOP}/erts/emulator/ryu/xcharconv_ryu.h.sha, isn't it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the point here is that it cannot be done automatically. I'll see what I can do to handle this scenario better.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated it so that a comment is posted to the PR that the update needs to be done manually in this scenario.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should document somewhere how the update scripts work, overall, and not just ryu.

  • If someone wants to update vendor dependencies, we should document that this can be done calling update-vendored-deps.sh instead of each individual update.sh file,
  • that a .githubtoken file must exist "somewhere" as a requirement, in order to run it locally,
  • that update.sh files will do a commit and update the vendor.info files,
  • the <vendor>.sha is there only for documentation purposes, and
  • update-vendored-deps.sh should run in local mode if you run it outside Github CI/CD, which avoids pushing to remote (default flag should be to run without push, so that only when we run in Github CI/CD we pass the flag to push, which is safer default than the opposite).

Maybe I am overthinking this, but there is a connection between scripts that we will forget with time.
If the scripts do not work, we should understand how to fix it in 1 min and its connection

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that you should call this script to update vendored deps, instead the individual update.sh scripts should be called directly. This script should only be used by github actions to generate updates.

The reason for this is that you most likely don't want to update all the deps, only a specific one as otherwise you may have to deal with fixing API issues in the jit because of an asmjit update when all you wanted to do was to update jquery to the latest version.

@garazdawi garazdawi requested a review from kikofernandez May 23, 2025 12:28
kikofernandez
kikofernandez previously approved these changes May 23, 2025
This change moves github actions updating to renovate and adds
monitoring of vendored dependencies as well as automatically
providing the code needed for the update.
@garazdawi garazdawi force-pushed the lukas/gh/add-renovate-3pps branch from 1c4d841 to cdf958a Compare May 27, 2025 13:43
@garazdawi garazdawi requested a review from kikofernandez May 27, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:VM Assigned to OTP team VM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants