Skip to content

erts: fix tcp_send_error econnaborted for win32 #10362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Nov 20, 2025
Merged

erts: fix tcp_send_error econnaborted for win32 #10362

1 commit merged into from
Nov 20, 2025

Conversation

@themiron
Copy link
Contributor

@themiron themiron commented Nov 10, 2025 •
edited
Loading 

otp$ fgrep -r __WIN_32__ . | wc -l
1
otp$ fgrep -r __WIN32__ . | wc -l
896

found with pvs studio, see https://pvs-studio.ru/ru/blog/posts/cpp/1305/

@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2025 •
edited
Loading

CT Test Results

    3 files    135 suites   49m 23s ⏱️
1 655 tests 1 598 ✅ 57 💤 0 ❌
2 293 runs  2 217 ✅ 76 💤 0 ❌

Results for commit e59830c.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@CLAassistant
Copy link

CLAassistant commented Nov 10, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@IngelaAndin IngelaAndin added the team:PS Assigned to OTP team PS label Nov 13, 2025
@michallepicki michallepicki mentioned this pull request Nov 13, 2025
Open
@IngelaAndin IngelaAndin requested review from RaimoNiskanen and bmk and removed request for bmk November 18, 2025 12:50
bmk
bmk previously approved these changes Nov 19, 2025
View reviewed changes
@RaimoNiskanen RaimoNiskanen mentioned this pull request Nov 19, 2025
Merged
@RaimoNiskanen RaimoNiskanen changed the title ears: fix tcp_send_error econnaborted for win32 erts: fix tcp_send_error econnaborted for win32 Nov 19, 2025
@RaimoNiskanen RaimoNiskanen changed the base branch from master to maint November 19, 2025 11:05
RaimoNiskanen
RaimoNiskanen approved these changes Nov 19, 2025
View reviewed changes
Copy link
Contributor

@RaimoNiskanen RaimoNiskanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased it on 'maint' and removed the commit comment part about the number of occurrences of __WIN32__ in the whole code base.

The golden rule here, in my opinion, is the surrounding code, and in inet_drv.c itself there are around 80 tests for __WIN32__, and more importantly no other WIN macro is used. So this is obviously a spelling error.

The conclusion is the same, the patch is perfectly right, but my motivation slightly different...

I also changed the misspelling of "ears" to "erts'.

@RaimoNiskanen RaimoNiskanen closed this pull request by merging all changes into erlang:maint in 3b1a2be Nov 20, 2025
@RaimoNiskanen RaimoNiskanen linked an issue Nov 21, 2025 that may be closed by this pull request
Multiple (minorish?) issues with core code detected by the PVS Studio static analyser #10370
Open
@RaimoNiskanen RaimoNiskanen removed a link to an issue Nov 21, 2025
Multiple (minorish?) issues with core code detected by the PVS Studio static analyser #10370
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RaimoNiskanen RaimoNiskanen RaimoNiskanen approved these changes

@bmk bmk bmk left review comments

Assignees

@RaimoNiskanen RaimoNiskanen

Labels

team:PS Assigned to OTP team PS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@themiron @CLAassistant @bmk @RaimoNiskanen @IngelaAndin