Add support for Mac OS < 10.15 #889
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added fallback for unsupported aligned_alloc Mac OS < 10.15 so it uses posix_memalign as per the current Android implementation.
|
It might also be worth considering using just |
|
If this is important to support I would add padding like SDL does and not use aligned allocators. However, I'm not supporting x86 macs either. So I'm not sure if this is worthwhile. |
|
That is fair. I didn’t see a clear note on not supporting x86 Mac’s in terms of platforms and just made the code change based on the warning from Xcode. It’s good to know as I am looking to use the new version for a Mac project. Thanks again for such a great library!On Feb 19, 2025, at 5:26 PM, Daniel Barber ***@***.***> wrote:That is a fair. It looks like the Sent from my iPhoneOn Feb 19, 2025, at 5:21 PM, Erin Catto ***@***.***> wrote:
If this is important to support I would add padding like SDL does and not use aligned allocators. However, I'm not supporting x86 macs either. So I'm not sure if this is worthwhile.—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
erincatto left a comment (erincatto/box2d#889)
If this is important to support I would add padding like SDL does and not use aligned allocators. However, I'm not supporting x86 macs either. So I'm not sure if this is worthwhile.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with the Box2D source in Xcode there is a single warning for Box2D in src/core.c the line
void* ptr = aligned_alloc( B2_ALIGNMENT, size32 );. Xcode warns that aligned_alloc was only introduced in Mac OS version 10.15. I've modified the file to include some code that should allow Box2D to run on older versions of Mac OS, but I don't have 10.14 or a previous version installed to test. The modified code still works when built on a newer version of Mac OS.I will aim to install a VM running 10.14 and test this at some point, but it might take a while.