Added cookies example with normal and cookiejar implementation #39
Conversation
| @@ -0,0 +1,24 @@ | |||
| # Cookie example | |||
|
|
|||
| We can achieve cookies by different ways: | |||
There was a problem hiding this comment.
We can read cookies in different ways:
| */ | ||
|
|
||
| // or if you want to enhance your | ||
| // cookie control over multiple users with multiple cookies. |
There was a problem hiding this comment.
What do you mean with multiple users?
There was a problem hiding this comment.
In the case of a you are developing a huge webpage (as github or a university intranet) you could need to handle multiple cookies with multiple users (clients).
There was a problem hiding this comment.
But what would be the advantage of adding the cookies to the jar and then all to the response at once vs just adding them to the response immediately?
There was a problem hiding this comment.
I created this library to store client cookies across requests and also I implemented to the server response.
| cookies.Put(cookie2) | ||
|
|
||
| // writting to the response header | ||
| cookies.WriteToResponse(&ctx.Response) |
There was a problem hiding this comment.
Isn't it better to call this method AddToResponse since it doesn't write anything but adds it to the response headers?
There was a problem hiding this comment.
I am not good choosing function names. I will change it
| ctx.Response.Header.SetCookie(cookie) | ||
| ctx.Response.Header.SetCookie(cookie1) | ||
| ctx.Response.Header.SetCookie(cookie2) | ||
| */ |
There was a problem hiding this comment.
I would just use this code for the example. Using the cookiejar here just adds extra allocations and extra lines of code that add nothing. Calling ctx.Response.Header.SetCookie for each cookie is much simpler than creating a cookiejar and calling cookies.Put for each cookie.
There was a problem hiding this comment.
Do you suggest to skip cookiejar example for server?
There was a problem hiding this comment.
I'm wondering if cookiejar is really that useful at all. What can you really do with it that you can't easily do with the functions already provided in fasthttp?
There was a problem hiding this comment.
I made it keeping in mind the client usage. You can see the usage of cookiejar in https://github.com/LibreLABUA/duac/blob/master/http.go#L26
Using fasthttp functions I'd have to parse cookie array or pointer to cookie array.
There was a problem hiding this comment.
Ah I get it. That shows much better use of the cookiejar where you want future requests to include cookies from previous responses. An example like that is much better, I suggest you rewrite this example to something like that. What you are doing in this pull request doesn't require a cookiejar at all.
But in this case I would also suggest improving the cookiejar code. A proper cookiejar should seperate cookies per domain, your cookiejar now combines cookies from all domains. Also Set-Cookie with an expire time in the past should remove the cookie from the jar. For a good example see the buildin cookiejar: https://golang.org/pkg/net/http/cookiejar/
There was a problem hiding this comment.
Oh, I forgot this. Okay, I am going to enhance cookiejar library. After that I will reedit the example. Thank you Erik
| cookie.Reset() | ||
|
|
||
| // 2. You can parse request header 'Set-Cookie' field. | ||
| // But with this method you just can get the first cookie value. |
There was a problem hiding this comment.
But with this method you can only get the first cookie.
|
|
||
| 1. Using 'key' parameter. Fasthttp will search using key in cookie field. | ||
|
|
||
| 2. You can parse request header 'Set-Cookie' field. |
There was a problem hiding this comment.
- Parsing the Set-Cookie header.
|
|
||
| 2. You can parse request header 'Set-Cookie' field. | ||
|
|
||
| 3. You can use 'PeekCookie' from ResponseHeader using key. This is the long way to get cookie instead of using 'Cookie' structure. |
There was a problem hiding this comment.
headers.PeekCookie and headers.Cookie do exactly the same thing except PeekCookie doesn't parse the headers if they aren't parsed yet.
| # How to run | ||
|
|
||
| ``` | ||
| ./server & # This command will start http server in background |
There was a problem hiding this comment.
This command will start the http server in the background
| cookie.SetKey("key") | ||
|
|
||
| res.Header.Cookie(cookie) | ||
| fmt.Printf("You cookie is '%s' found using '%s' key\n", cookie.Cookie(), cookie.Key()) |
There was a problem hiding this comment.
Your cookie is '%s' found using '%s' as key
|
|
||
| fmt.Printf("\nYour cookies:\n") | ||
| for { | ||
| cookie := cookies.Get() |
There was a problem hiding this comment.
Your examples above look at the value of a specific cookie, if you really want to show the cookiejar here you should also use cookies.Peek("key") here to keep the examples the same.
This is a cookie example using normal api and cookiejar fasthttp's implementation.