cmd: move dev/snapshots and common to cli sublibraries

[canepat]

• support "cli" sublibraries in silkworm_library
• reorg cmd/common as infra/cli
• move module-specific options to db/cli, node/cli, rpc/cli and sentry/cli
• move dev/snapshots sources to db/cli (executable is still defined in cmd)

[battlmonstr]

great job 👍 , see comments

[battlmonstr]

ASAN failure is not related to this PR, it was broken on master since #2561

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.20%. Comparing base (c326201) to head (8d67bea).
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2574      +/-   ##
==========================================
- Coverage   51.56%   51.20%   -0.36%     
==========================================
  Files         762      771       +9     
  Lines       51724    52092     +368     
  Branches     8023     8047      +24     
==========================================
+ Hits        26669    26672       +3     
- Misses      22750    23121     +371     
+ Partials     2305     2299       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[battlmonstr]

see 1 comment, otherwise LGTM 👍

[battlmonstr]

This should be placed right after list_filter_dirs(SRC SUB_LIBS) line, otherwise TEST_SRC will get "cli/*" sources included. Perhaps we should rename the initial SRC to ALL_SRC, and then set(SRC ${ALL_SRC}) to avoid this confusion. Sorry for this.

[battlmonstr]

I've moved it.

[battlmonstr]

@canepat dev/snapshots.cpp is moved to db/cli, but add_executable(snapshots) is still in dev/CMakeLists.txt. Is there anything that prevents moving it to db/cli/CMakeLists.txt ? One thing that comes to my mind is that cmake/run_smoke_tests.cmake COMMANDS search logic needs to be extended by recursing into cli subdirectories in addition to cmd. This can be done in a follow-up PR.